Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Michael Paquier wrote: When running the test suite of ecpg, build generates a set of obj files and it happens that those files are not ignored in the code tree. Wouldn't this be simpler as a *.obj pattern somewhere? Maybe in

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Michael Meskes
When running the test suite of ecpg, build generates a set of obj files and it happens that those files are not ignored in the code tree. Applied, thanks. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Alvaro Herrera
Michael Paquier wrote: Hi all, When running the test suite of ecpg, build generates a set of obj files and it happens that those files are not ignored in the code tree. Wouldn't this be simpler as a *.obj pattern somewhere? Maybe in ecpg/test/.gitignore add this line? **/*.obj -- Álvaro

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Andrew Dunstan
On 03/09/2015 11:31 AM, Michael Meskes wrote: Actually, if we are supporting toolchains that generate *.obj files, I'd expect the top-level .gitignore to ignore them, as it does *.o. But if that's the issue why have we not heard complaints before? ... +1 for adding a top level .gitignore

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 03/09/2015 11:31 AM, Michael Meskes wrote: I don't have a Windows system to test on, but how come these files were only created in the ecpg testsuite? With the global .gitignore not mentioning *.obj it appears those files are not created anywhere

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Michael Meskes
Actually, if we are supporting toolchains that generate *.obj files, I'd expect the top-level .gitignore to ignore them, as it does *.o. But if that's the issue why have we not heard complaints before? ... +1 for adding a top level .gitignore entry. I don't have a Windows system to test on,

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Andrew Dunstan
On 03/09/2015 09:46 AM, Tom Lane wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Michael Paquier wrote: When running the test suite of ecpg, build generates a set of obj files and it happens that those files are not ignored in the code tree. Wouldn't this be simpler as a *.obj pattern

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Michael Meskes
On 09.03.2015 16:58, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: The MSVC build creates project directories which contain all the .obj files etc. The file locations for intermediate artefacts are quite different from the way a Unix build works. There is an ignore rule for

Re: [HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Michael Paquier
On Tue, Mar 10, 2015 at 2:50 AM, Michael Meskes mes...@postgresql.org wrote: On 09.03.2015 16:58, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: The MSVC build creates project directories which contain all the .obj files etc. The file locations for intermediate artefacts are quite

[HACKERS] Object files generated by ecpg test suite not ignored on Windows

2015-03-09 Thread Michael Paquier
Hi all, When running the test suite of ecpg, build generates a set of obj files and it happens that those files are not ignored in the code tree. Patch is attached. Regards, -- Michael diff --git a/src/interfaces/ecpg/test/compat_informix/.gitignore