At Mon, 24 Jul 2017 10:23:07 +0530, Ashutosh Bapat
wrote in
> On Fri, Jul 21, 2017 at 10:39 PM, Tom Lane wrote:
> > Ashutosh Bapat writes:
> >> On Fri, Jul 21, 2017 at 10:55 AM, Kyotaro HORIGUCHI
> >> wrote:
> >>> The attached patch differs only in this point.
> >
> >> +1. The patch looks go
On Fri, Jul 21, 2017 at 10:39 PM, Tom Lane wrote:
> Ashutosh Bapat writes:
>> On Fri, Jul 21, 2017 at 10:55 AM, Kyotaro HORIGUCHI
>> wrote:
>>> The attached patch differs only in this point.
>
>> +1. The patch looks good to me.
>
> Pushed with a couple additional changes: we'd all missed that th
Ashutosh Bapat writes:
> On Fri, Jul 21, 2017 at 10:55 AM, Kyotaro HORIGUCHI
> wrote:
>> The attached patch differs only in this point.
> +1. The patch looks good to me.
Pushed with a couple additional changes: we'd all missed that the header
comment for GetConnection was obsoleted by this chan
On Fri, Jul 21, 2017 at 10:55 AM, Kyotaro HORIGUCHI
wrote:
> At Thu, 20 Jul 2017 18:15:42 -0400, Tom Lane wrote in
> <18927.1500588...@sss.pgh.pa.us>
>> This seems like overkill. We can test it reasonably easily within the
>> existing framework, as shown in the attached patch. I'm also fairly
On Fri, Jul 21, 2017 at 12:23 AM, Alvaro Herrera
wrote:
> Kyotaro HORIGUCHI wrote:
>> Finally, I added a new TAP test library PsqlSession. It offers
>> interactive psql sessions. Then added a simple test to
>> postgres_fdw using it.
>
> Hmm, I think this can be very useful for other things. Let's
At Thu, 20 Jul 2017 18:23:05 -0400, Alvaro Herrera
wrote in <20170720222305.ij3pk7qw5im3wozr@alvherre.pgsql>
> Kyotaro HORIGUCHI wrote:
>
> > Finally, I added a new TAP test library PsqlSession. It offers
> > interactive psql sessions. Then added a simple test to
> > postgres_fdw using it.
>
>
At Thu, 20 Jul 2017 18:15:42 -0400, Tom Lane wrote in
<18927.1500588...@sss.pgh.pa.us>
> This seems like overkill. We can test it reasonably easily within the
> existing framework, as shown in the attached patch. I'm also fairly
It checks for a disconnection caused in a single session. I
thoug
Kyotaro HORIGUCHI wrote:
> Finally, I added a new TAP test library PsqlSession. It offers
> interactive psql sessions. Then added a simple test to
> postgres_fdw using it.
Hmm, I think this can be very useful for other things. Let's keep this
in mind to use in the future, even if we find another
Kyotaro HORIGUCHI writes:
> Here it is. First I tried this using ordinary regression
> framework but the effect of this patch is shown only in log and
> it contains variable parts so I gave up it before trying more
> complex way.
> Next I tried existing TAP test but this test needs continuous
> s
Finally, I added new TAP test library PsqlSession.
At Tue, 18 Jul 2017 18:12:13 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
wrote in
<20170718.181213.206979369.horiguchi.kyot...@lab.ntt.co.jp>
> > * How about some regression test cases? You couldn't really exercise
> > cross-session invalid
Thank you for the comments.
At Mon, 17 Jul 2017 16:09:04 -0400, Tom Lane wrote in
<9897.1500322...@sss.pgh.pa.us>
> Kyotaro HORIGUCHI writes:
> > This is the revased and revised version of the previous patch.
>
> A few more comments:
>
> * Per the spec for CacheRegisterSyscacheCallback, a zer
Kyotaro HORIGUCHI writes:
> This is the revased and revised version of the previous patch.
A few more comments:
* Per the spec for CacheRegisterSyscacheCallback, a zero hash value means
to flush all associated state. This isn't handling that case correctly.
Even when you are given a specific ha
On Fri, Jul 14, 2017 at 2:04 PM, Kyotaro HORIGUCHI
wrote:
> Thank you for the comments.
>
> At Thu, 13 Jul 2017 16:54:42 +0530, Ashutosh Bapat
> wrote in
>
>> On Thu, Jul 13, 2017 at 2:53 PM, Kyotaro HORIGUCHI
>> wrote:
>> > Hello, moved to pgsql-hackers.
>> >
>> > This is the revased and rev
Thank you for the comments.
At Thu, 13 Jul 2017 16:54:42 +0530, Ashutosh Bapat
wrote in
> On Thu, Jul 13, 2017 at 2:53 PM, Kyotaro HORIGUCHI
> wrote:
> > Hello, moved to pgsql-hackers.
> >
> > This is the revased and revised version of the previous patch.
> >
> > At Thu, 13 Jul 2017 13:42:49
On Thu, Jul 13, 2017 at 2:53 PM, Kyotaro HORIGUCHI
wrote:
> Hello, moved to pgsql-hackers.
>
> This is the revased and revised version of the previous patch.
>
> At Thu, 13 Jul 2017 13:42:49 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
> wrote in
> <20170713.134249.97825982.horiguchi.kyot...@
Hello, moved to pgsql-hackers.
This is the revased and revised version of the previous patch.
At Thu, 13 Jul 2017 13:42:49 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
wrote in
<20170713.134249.97825982.horiguchi.kyot...@lab.ntt.co.jp>
> At Tue, 11 Jul 2017 15:39:14 -0400, Tom Lane wrote in
16 matches
Mail list logo
