Re: [HACKERS] Random inconsistencies in GiST support function declarations

2016-03-02 Thread Tom Lane
Jeff Janes writes: > This work (9ff60273e35cad6e9) seems have broken pg_upgrade when > tsearch2 is installed. > On an empty 9.4 instance with nothing but tsearch2 installed, using > HEAD's pg_upgrade gives this error: > pg_restore: creating OPERATOR CLASS "public.gin_tsvector_ops" > pg_restore:

Re: [HACKERS] Random inconsistencies in GiST support function declarations

2016-03-01 Thread Jeff Janes
On Mon, Jan 18, 2016 at 2:29 PM, Tom Lane wrote: > > Fixing the pg_proc entries in HEAD seems like no big deal, but some of > the errors are in contrib modules. If we wanted to be really clean > about that, we'd have to bump those modules' extension versions, which > is a pain in the rear. Since

[HACKERS] Random inconsistencies in GiST support function declarations

2016-01-18 Thread Tom Lane
I was idly trying to improve the just-added index AM amvalidate() functions by having them verify the expected signatures (argument and result types) of opclass support functions. opr_sanity currently does this for btree, hash, and spgist functions, but not for other cases; it'd be useful IMO if w