Re: [HACKERS] Re: [COMMITTERS] pgsql: Add COMMENT and SECURITY LABEL support for publications and subs

2017-04-13 Thread Peter Eisentraut
On 4/4/17 09:59, Stephen Frost wrote: >> Attached is a patch that adds the pg_dump support, but I'm struggling to >> make the tests work. Could you take a look? Problem one I'm seeing is >> that the tests assert that there are no comments in the post-data >> section, which is no longer the case

[HACKERS] Re: [COMMITTERS] pgsql: Add COMMENT and SECURITY LABEL support for publications and subs

2017-04-04 Thread Stephen Frost
Peter, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 3/25/17 12:24, Stephen Frost wrote: > >> Add COMMENT and SECURITY LABEL support for publications and subscriptions > > > > Isn't this missing psql tab completion, and pg_dump support? And > > regression tests for the

[HACKERS] Re: [COMMITTERS] pgsql: Add COMMENT and SECURITY LABEL support for publications and subs

2017-04-04 Thread Peter Eisentraut
On 3/25/17 12:24, Stephen Frost wrote: >> Add COMMENT and SECURITY LABEL support for publications and subscriptions > > Isn't this missing psql tab completion, and pg_dump support? And > regression tests for the latter? I have added the tab completion support. Attached is a patch that adds the