Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-20 Thread Heikki Linnakangas

On 02/20/2014 04:15 AM, Peter Geoghegan wrote:

On Wed, Feb 19, 2014 at 4:49 PM, Michael Paquier
michael.paqu...@gmail.com wrote:

+1 for back-patching.

Back-patching would be interesting for existing applications, but -1
as it is a new feature :)


I think that it rises to the level of an omission in 9.3 that now
requires correction. Many of our users couldn't run pg_controldata
even if they'd heard of it...


We seem to have +Many against -1, so back-patched it now.

- Heikki


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread Bernd Helmle



--On 18. Februar 2014 22:23:59 +0200 Heikki Linnakangas hlinn...@iki.fi 
wrote:



I considered it a new feature, so not back-patching was the default. If
you want to back-patch it, I won't object.


That was my original feeling, too, but +1 for backpatching.

--
Thanks

Bernd


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread David Fetter
On Tue, Feb 18, 2014 at 04:39:27PM -0300, Alvaro Herrera wrote:
 Heikki Linnakangas wrote:
  Add a GUC to report whether data page checksums are enabled.
 
 Is there are reason this wasn't back-patched to 9.3?  I think it should
 be.

+1 for back-patching.

Cheers,
David.
-- 
David Fetter da...@fetter.org http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter  XMPP: david.fet...@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread Michael Paquier
On Thu, Feb 20, 2014 at 1:01 AM, David Fetter da...@fetter.org wrote:
 On Tue, Feb 18, 2014 at 04:39:27PM -0300, Alvaro Herrera wrote:
 Heikki Linnakangas wrote:
  Add a GUC to report whether data page checksums are enabled.

 Is there are reason this wasn't back-patched to 9.3?  I think it should
 be.

 +1 for back-patching.
Back-patching would be interesting for existing applications, but -1
as it is a new feature :)
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread Peter Geoghegan
On Wed, Feb 19, 2014 at 4:49 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
 +1 for back-patching.
 Back-patching would be interesting for existing applications, but -1
 as it is a new feature :)

I think that it rises to the level of an omission in 9.3 that now
requires correction. Many of our users couldn't run pg_controldata
even if they'd heard of it...


-- 
Peter Geoghegan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Alvaro Herrera
Heikki Linnakangas wrote:
 Add a GUC to report whether data page checksums are enabled.

Is there are reason this wasn't back-patched to 9.3?  I think it should
be.



-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Peter Geoghegan
On Tue, Feb 18, 2014 at 11:39 AM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
 Is there are reason this wasn't back-patched to 9.3?  I think it should
 be.

+1.


-- 
Peter Geoghegan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Heikki Linnakangas

On 02/18/2014 09:39 PM, Alvaro Herrera wrote:

Heikki Linnakangas wrote:

Add a GUC to report whether data page checksums are enabled.


Is there are reason this wasn't back-patched to 9.3?  I think it should
be.


I considered it a new feature, so not back-patching was the default. If 
you want to back-patch it, I won't object.


- Heikki


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Andres Freund
On 2014-02-18 22:23:59 +0200, Heikki Linnakangas wrote:
 On 02/18/2014 09:39 PM, Alvaro Herrera wrote:
 Heikki Linnakangas wrote:
 Add a GUC to report whether data page checksums are enabled.
 
 Is there are reason this wasn't back-patched to 9.3?  I think it should
 be.

Thirded.

 I considered it a new feature, so not back-patching was the default. If you
 want to back-patch it, I won't object.

Imo it's essentially a simple oversight in the checksum patch...

Greetings,

Andres Freund

-- 
 Andres Freund http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers