[HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-18 Thread Noah Misch
On Mon, Apr 18, 2016 at 11:56:55PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Mon, Apr 18, 2016 at 10:22:59PM -0400, Tom Lane wrote: > >> We could alternatively set extra_float_digits to its max value and hope > >> that off-by-one-in-the-last-place values would get printed as something > >

[HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-18 Thread Noah Misch
On Mon, Apr 18, 2016 at 10:22:59PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Mon, Apr 18, 2016 at 09:17:46AM -0400, Tom Lane wrote: > >> Given that it's apparently showing the results of asind as NULL ... > > > I doubt asind is returning NULL. Here's the query, which uses a CASE to > >

[HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-18 Thread Noah Misch
On Mon, Apr 18, 2016 at 09:17:46AM -0400, Tom Lane wrote: > Michael Paquier writes: > > On Mon, Apr 18, 2016 at 12:31 PM, Peter Eisentraut wrote: > >> I don't know if it's worth tracking this as an open item and thus > >> kind-of release blocker if no one else has the problem. But I > >> definit

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-18 Thread Tom Lane
Michael Paquier writes: > On Mon, Apr 18, 2016 at 12:31 PM, Peter Eisentraut wrote: >> I don't know if it's worth tracking this as an open item and thus >> kind-of release blocker if no one else has the problem. But I >> definitely still have it. My initial suspicion was that this had >> someth

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-17 Thread Michael Paquier
On Mon, Apr 18, 2016 at 12:31 PM, Peter Eisentraut wrote: > I don't know if it's worth tracking this as an open item and thus > kind-of release blocker if no one else has the problem. But I > definitely still have it. My initial suspicion was that this had > something to do with a partial upgrad

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-17 Thread Peter Eisentraut
On 04/15/2016 02:04 PM, Robert Haas wrote: > Peter, are you going to look into this further? This is on the open > items list, but there seems to be nothing that can be done about it by > anyone other than, maybe, you. I don't know if it's worth tracking this as an open item and thus kind-of rele

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-15 Thread Robert Haas
On Fri, Apr 8, 2016 at 5:48 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 01/22/2016 03:46 PM, Tom Lane wrote: >>> Add trigonometric functions that work in degrees. > >> I have a host here that is having regression test failures from this commit: > >> --- src/test/regress/expected/float8.o

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-08 Thread Tom Lane
Peter Eisentraut writes: > On 01/22/2016 03:46 PM, Tom Lane wrote: >> Add trigonometric functions that work in degrees. > I have a host here that is having regression test failures from this commit: > --- src/test/regress/expected/float8.out > +++ src/test/regress/results/float8.out > @@ -490,9

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-07 Thread Tom Lane
Peter Eisentraut writes: > On 04/04/2016 09:20 PM, Michael Paquier wrote: >> Likely an oversight not tracked by the buildfarm. What are you using here? > It should be a rather unspectactular Debian system. I have tried a > bunch of different compilers and optimization options, without success.

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-07 Thread Peter Eisentraut
On 04/04/2016 09:20 PM, Michael Paquier wrote: Likely an oversight not tracked by the buildfarm. What are you using here? It should be a rather unspectactular Debian system. I have tried a bunch of different compilers and optimization options, without success. I'll keep looking. -- Sent

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-04 Thread Tom Lane
Michael Paquier writes: > On Tue, Apr 5, 2016 at 10:16 AM, Peter Eisentraut wrote: >> On 01/22/2016 03:46 PM, Tom Lane wrote: >>> Add trigonometric functions that work in degrees. >> I have a host here that is having regression test failures from this commit: > Likely an oversight not tracked b

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-04 Thread Michael Paquier
On Tue, Apr 5, 2016 at 10:16 AM, Peter Eisentraut wrote: > On 01/22/2016 03:46 PM, Tom Lane wrote: >> >> Add trigonometric functions that work in degrees. >> >> The implementations go to some lengths to deliver exact results for values >> where an exact result can be expected, such as sind(30) = 0

[HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-04 Thread Peter Eisentraut
On 01/22/2016 03:46 PM, Tom Lane wrote: Add trigonometric functions that work in degrees. The implementations go to some lengths to deliver exact results for values where an exact result can be expected, such as sind(30) = 0.5 exactly. I have a host here that is having regression test failures