Re: [HACKERS] Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

2016-04-01 Thread Alvaro Herrera
Craig Ringer wrote: > Note that I can't use PG_GETARG_TRANSACTIONID directly since it's a macro > defined only in xid.c . It didn't seem worth extracting it and moving it to > postgres.h (where the other non-ADT-specific PG_GETARG_ macros are) or its > own new header just for this, so I've spelled

Re: [HACKERS] Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

2016-03-31 Thread Craig Ringer
On 1 April 2016 at 12:47, Craig Ringer wrote: > I'll prep a follow-up patch. > > Done and attached. Note that I can't use PG_GETARG_TRANSACTIONID directly since it's a macro defined only in xid.c . It didn't seem worth extracting it and moving it to postgres.h (where the other non-ADT-specific

Re: [HACKERS] Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

2016-03-31 Thread Craig Ringer
On 1 April 2016 at 11:13, Petr Jelinek wrote: > > The function does following: > TransactionId new_xmin = (TransactionId) PG_GETARG_INT64(1); > This should be reasonable enough though; down-casting it will discard the high bits but that's fine when we know there's nothing interesting there. Tr

Re: [HACKERS] Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

2016-03-31 Thread Petr Jelinek
On 01/04/16 03:49, Alvaro Herrera wrote: > Moving thread to -hackers, CC'ing Craig. > > Michael Paquier wrote: > >> hamster complains here: >> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamster&dt=2016-03-31%2016%3A00%3A06 >> [...] >> # Copying slots to replica >> after_basebackup|test_

[HACKERS] Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

2016-03-31 Thread Alvaro Herrera
Moving thread to -hackers, CC'ing Craig. Michael Paquier wrote: > hamster complains here: > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamster&dt=2016-03-31%2016%3A00%3A06 > [...] > # Copying slots to replica > after_basebackup|test_decoding||547|0/560|0/598 > # Copying slot