Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Sat, Mar 25, 2017 at 2:42 AM, Fujii Masao wrote: > On Thu, Mar 23, 2017 at 4:28 AM, Fujii Masao wrote: >> On Wed, Mar 15, 2017 at 7:51 PM, Masahiko Sawada >> wrote: >>> On Wed, Mar 15, 2017 at 1:09 PM, Yugo Nagata

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Thu, Mar 23, 2017 at 4:28 AM, Fujii Masao wrote: > On Wed, Mar 15, 2017 at 7:51 PM, Masahiko Sawada > wrote: >> On Wed, Mar 15, 2017 at 1:09 PM, Yugo Nagata wrote: >>> On Fri, 10 Mar 2017 20:08:42 +0900 >>> Masahiko Sawada

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Wed, Mar 15, 2017 at 7:51 PM, Masahiko Sawada wrote: > On Wed, Mar 15, 2017 at 1:09 PM, Yugo Nagata wrote: >> On Fri, 10 Mar 2017 20:08:42 +0900 >> Masahiko Sawada wrote: >> >>> On Fri, Mar 10, 2017 at 3:58 PM, Jim Nasby

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Wed, Mar 15, 2017 at 1:09 PM, Yugo Nagata wrote: > On Fri, 10 Mar 2017 20:08:42 +0900 > Masahiko Sawada wrote: > >> On Fri, Mar 10, 2017 at 3:58 PM, Jim Nasby wrote: >> > On 3/6/17 8:34 PM, Masahiko Sawada wrote: >> >> >> >>

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Fri, 10 Mar 2017 20:08:42 +0900 Masahiko Sawada wrote: > On Fri, Mar 10, 2017 at 3:58 PM, Jim Nasby wrote: > > On 3/6/17 8:34 PM, Masahiko Sawada wrote: > >> > >> I don't think it can say "1 frozen pages" because the number of > >> skipped pages

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On 3/10/17 5:08 AM, Masahiko Sawada wrote: BTW, I think there's already a function that handles the pluralization for you. IIRC it's one of the things you can add to an ereport() call. What is the function name? A quick `git grep plural` shows errdetail_plural and errmsg_plural. -- Jim Nasby,

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Fri, Mar 10, 2017 at 3:58 PM, Jim Nasby wrote: > On 3/6/17 8:34 PM, Masahiko Sawada wrote: >> >> I don't think it can say "1 frozen pages" because the number of >> skipped pages according to visibility map is always more than 32 >> (SKIP_PAGES_THRESHOLD). > > > That's

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On 3/6/17 8:34 PM, Masahiko Sawada wrote: I don't think it can say "1 frozen pages" because the number of skipped pages according to visibility map is always more than 32 (SKIP_PAGES_THRESHOLD). That's just an artifact of how the VM currently works. I'm not a fan of cross dependencies like

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Mon, Mar 6, 2017 at 12:12 PM, Yugo Nagata wrote: > Hi, > > I think this is good since the information is useful and it is > a little change. Thank you for reviewing this patch! > > One thing I'm bothered is that even when the number of frozen page is > one, it will say

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

Hi, I think this is good since the information is useful and it is a little change. One thing I'm bothered is that even when the number of frozen page is one, it will say "1 frozen pages". In other messages, when the number of page is one, the word "page" rather than "pages" is used by using

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Fri, Feb 24, 2017 at 1:30 AM, Masahiko Sawada wrote: > Hi all, > > The autovacuum reports the number of skipped frozen pages to the > VACUUM output. But these information is not appeared by manual VACUUM. > This information is useful for the user to check efficiency of

[HACKERS] Report the number of skipped frozen pages by manual VACUUM

Hi all, The autovacuum reports the number of skipped frozen pages to the VACUUM output. But these information is not appeared by manual VACUUM. This information is useful for the user to check efficiency of VACUUM. Attached patch add this information to VACUUM output. * Example =# VACUUM