Re: [HACKERS] SLRU limits

2011-10-14 Thread Bruce Momjian
Is this a TODO? --- Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: On 09.06.2011 15:50, Robert Haas wrote: And I would guess that there's a lot more interest in raising BLCKSZ than

Re: [HACKERS] SLRU limits

2011-10-14 Thread Kevin Grittner
Bruce Momjian br...@momjian.us wrote: Is this a TODO? Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: If we don't want to change it wholesale, one option would be to support different lengths of filenames in slru.c for different slrus. At a quick glance,

[HACKERS] SLRU limits

2011-06-09 Thread Heikki Linnakangas
While reviewing the SLRU code in predicate.c again, I remembered this old thread: http://archives.postgresql.org/pgsql-hackers/2010-12/msg02374.php SLRU has a limit of 64k segment files, because the files are named using four hex digits like 00CE. Kevin's math shows that that's just enough

Re: [HACKERS] SLRU limits

2011-06-09 Thread Robert Haas
On Thu, Jun 9, 2011 at 7:46 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: While reviewing the SLRU code in predicate.c again, I remembered this old thread: http://archives.postgresql.org/pgsql-hackers/2010-12/msg02374.php SLRU has a limit of 64k segment files, because the

Re: [HACKERS] SLRU limits

2011-06-09 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: It's awfully late in the release cycle, but how about we add another digit to the filenames used by SLRU, to up the limit? It's way too late for that kind of thing, unless you are saying that SSI in and of itself is going to cause

Re: [HACKERS] SLRU limits

2011-06-09 Thread Heikki Linnakangas
On 09.06.2011 15:50, Robert Haas wrote: On Thu, Jun 9, 2011 at 7:46 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: While reviewing the SLRU code in predicate.c again, I remembered this old thread: http://archives.postgresql.org/pgsql-hackers/2010-12/msg02374.php SLRU has a

Re: [HACKERS] SLRU limits

2011-06-09 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: On 09.06.2011 15:50, Robert Haas wrote: And I would guess that there's a lot more interest in raising BLCKSZ than lowering it. It might not be a bad idea to adopt the fix you propose anyway, but it doesn't seem urgent. I guess

Re: [HACKERS] SLRU limits

2011-06-09 Thread Heikki Linnakangas
On 09.06.2011 19:24, Tom Lane wrote: (BTW, while I've not looked at the SLRU code in several years, I'm quite unconvinced that this is only a matter of filename lengths.) I don't see anything but the filename length needing adjustment. In fact, when I hacked predicate.c to ignore the issue