Re: [HACKERS] Small doc patch for pg_replication_slots
Le 01/05/2014 04:56, Robert Haas a écrit : On Tue, Apr 29, 2014 at 5:39 AM, Thomas Reiss thomas.re...@dalibo.com wrote: You can find attached a small patch to fix the pg_replication_slots documentation. The slot_type and plugin are not in the appropriate order, slot_name and plugin have a wrong type and xmin appears two times. Without the patch, the description of catalog_xmin is: entryThe literalxmin/literal, or oldest transaction ID, that this slot forces to be retained in the system catalogs. /entry With the patch it's: entryThe oldest transaction that this slot needs the database to retain. literalVACUUM/literal cannot remove catalog tuples deleted by any later transaction. That's only one word different from the language for xmin, which doesn't seem quite right. Committed after fixing that. ...Robert Thanks -- Thomas Reiss Consultant Dalibo http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Small doc patch for pg_replication_slots
On Tue, Apr 29, 2014 at 5:39 AM, Thomas Reiss thomas.re...@dalibo.com wrote: You can find attached a small patch to fix the pg_replication_slots documentation. The slot_type and plugin are not in the appropriate order, slot_name and plugin have a wrong type and xmin appears two times. Without the patch, the description of catalog_xmin is: entryThe literalxmin/literal, or oldest transaction ID, that this slot forces to be retained in the system catalogs. /entry With the patch it's: entryThe oldest transaction that this slot needs the database to retain. literalVACUUM/literal cannot remove catalog tuples deleted by any later transaction. That's only one word different from the language for xmin, which doesn't seem quite right. Committed after fixing that. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Small doc patch for pg_replication_slots
Hello, You can find attached a small patch to fix the pg_replication_slots documentation. The slot_type and plugin are not in the appropriate order, slot_name and plugin have a wrong type and xmin appears two times. Regards -- Thomas Reiss diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 415a3bc..d8c41d9 100644 --- a/doc/src/sgml/catalogs.sgml +++ b/doc/src/sgml/catalogs.sgml @@ -5252,23 +5252,23 @@ tbody row entrystructfieldslot_name/structfield/entry - entrytypetext/type/entry + entrytypename/type/entry entry/entry entryA unique, cluster-wide identifier for the replication slot/entry /row row - entrystructfieldslot_type/structfield/entry - entrytypetext/type/entry + entrystructfieldplugin/structfield/entry + entrytypename/type/entry entry/entry - entryThe slot type - literalphysical/ or literallogical//entry + entryThe basename of the shared object containing the output plugin this logical slot is using, or null for physical slots./entry /row row - entrystructfieldplugin/structfield/entry + entrystructfieldslot_type/structfield/entry entrytypetext/type/entry entry/entry - entryThe basename of the shared object containing the output plugin this logical slot is using, or null for physical slots./entry + entryThe slot type - literalphysical/ or literallogical//entry /row row @@ -5305,7 +5305,7 @@ /row row - entrystructfieldxmin/structfield/entry + entrystructfieldcatalog_xmin/structfield/entry entrytypexid/type/entry entry/entry entryThe oldest transaction that this slot needs the database to @@ -5315,14 +5315,6 @@ /row row - entrystructfieldcatalog_xmin/structfield/entry - entrytypexid/type/entry - entry/entry - entryThe literalxmin/literal, or oldest transaction ID, that this - slot forces to be retained in the system catalogs. /entry - /row - - row entrystructfieldrestart_lsn/structfield/entry entrytypepg_lsn/type/entry entry/entry -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
