Re: [HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-14 Thread Kurt Roeckx
On Thu, Feb 13, 2003 at 08:55:23PM -0500, Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I've done a little bit of cleanup, but that code is still a mess... > >> someone should rewrite these routines. > > > Yes, I looked at it and struggled to get both IPv4 an

Re: [HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I've done a little bit of cleanup, but that code is still a mess... >> someone should rewrite these routines. > Yes, I looked at it and struggled to get both IPv4 and IPv6 cleanly > working. Any ideas on how to improve it? The major

Re: [HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Speculation time: do you have the IPv6 code compiled in? I don't. > > > I have IPv6 enabled in the binary, but not the kernel. > > Sure enough, the IPV6 patch had broken error handling in the non-IPV6 > path. >

Re: [HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Speculation time: do you have the IPv6 code compiled in? I don't. > I have IPv6 enabled in the binary, but not the kernel. Sure enough, the IPV6 patch had broken error handling in the non-IPV6 path. I've done a little bit of cleanup

Re: [HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> In CVS tip, I'm getting only an empty string from psql where it should > >> print connection-failure messages. > > > [ it works here ] > > Speculation time: do you have the IPv6 code compiled in? I don't. I hav

Re: [HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> In CVS tip, I'm getting only an empty string from psql where it should >> print connection-failure messages. > [ it works here ] Speculation time: do you have the IPv6 code compiled in? I don't. regards, tom

Re: [HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-13 Thread Bruce Momjian
Tom Lane wrote: > In CVS tip, I'm getting only an empty string from psql where it should > print connection-failure messages. > > psql 7.3 does this: > > $ psql -p > psql: could not connect to server: No such file or directory > Is the server running locally and accepting > c

[HACKERS] Someone's broken psql's connection-failure error reporting

2003-02-13 Thread Tom Lane
In CVS tip, I'm getting only an empty string from psql where it should print connection-failure messages. psql 7.3 does this: $ psql -p psql: could not connect to server: No such file or directory Is the server running locally and accepting connections on Unix domain socket "