Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-12-12 Thread Heikki Linnakangas
On 11/29/2013 08:41 AM, Rajeev rastogi wrote: On 29 November 2013, Amit Kapila Wrote: Further Review of this patch: I have done few more cosmetic changes in your patch, please find the updated patch attached with this mail. Kindly check once whether changes are okay. Changes are fine.

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-12-12 Thread Rajeev rastogi
On 12 December 2013, Heikki Linnakangas Wrote: Further Review of this patch: I have done few more cosmetic changes in your patch, please find the updated patch attached with this mail. Kindly check once whether changes are okay. Changes are fine. Thanks you. I have uploaded the

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-28 Thread Amit Kapila
On Thu, Nov 28, 2013 at 12:11 PM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On 28 November 2013, Amit Kapila Wrote: Further Review of this patch: b. why to display 'First log segment after reset' in 'Currrent pg_control values' section as now the same information is available in

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-28 Thread Rajeev rastogi
On 29 November 2013, Amit Kapila Wrote: Further Review of this patch: b. why to display 'First log segment after reset' in 'Currrent pg_control values' section as now the same information is available in new section Values to be used after reset: ? May not be always. Suppose

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-28 Thread Amit Kapila
On Fri, Nov 29, 2013 at 10:00 AM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On 29 November 2013, Amit Kapila Wrote: Further Review of this patch: I have done few more cosmetic changes in your patch, please find the updated patch attached with this mail. Kindly check once whether

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-28 Thread Rajeev rastogi
On 29 November 2013, Amit Kapila Wrote: Further Review of this patch: I have done few more cosmetic changes in your patch, please find the updated patch attached with this mail. Kindly check once whether changes are okay. Changes are fine. Thanks you. I have uploaded the latest

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-27 Thread Amit Kapila
On Tue, Nov 26, 2013 at 5:33 PM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On 26 November 2013, Amit Kapila Wrote: Further Review of this patch: b. why to display 'First log segment after reset' in 'Currrent pg_control values' section as now the same information is available in new

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-27 Thread Rajeev rastogi
On 28 November 2013, Amit Kapila Wrote: Further Review of this patch: b. why to display 'First log segment after reset' in 'Currrent pg_control values' section as now the same information is available in new section Values to be used after reset: ? May not be always. Suppose if

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-26 Thread Rajeev rastogi
On 26 November 2013, Amit Kapila Wrote: Further Review of this patch: a. there are lot of trailing whitespaces in patch. Fixed. b. why to display 'First log segment after reset' in 'Currrent pg_control values' section as now the same information is available in new section Values to be

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-25 Thread Amit Kapila
On Mon, Nov 25, 2013 at 9:17 AM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On Sat, Nov 9, 2013, Amit Kapila wrote Further Review of this patch: a. there are lot of trailing whitespaces in patch. b. why to display 'First log segment after reset' in 'Currrent pg_control values' section as

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-24 Thread Rajeev rastogi
On Sat, Nov 9, 2013, Amit Kapila wrote On Fri, Nov 8, 2013 at 10:37 AM, Rajeev rastogi rajeev.rast...@huawei.commailto:rajeev.rast...@huawei.com wrote: On Fri, 08 November 2013 09:47 On Tue, Nov 5, 2013 at 3:20 PM, Rajeev rastogi

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-08 Thread Rajeev rastogi
On Fri, 08 November 2013 09:47 On Tue, Nov 5, 2013 at 3:20 PM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On execution of pg_resetxlog using the option -n 1. It will display values in two section. 2. First section will be called as Current

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-08 Thread Amit Kapila
On Fri, Nov 8, 2013 at 10:37 AM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On Fri, 08 November 2013 09:47 On Tue, Nov 5, 2013 at 3:20 PM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On execution of pg_resetxlog using the option -n Please provide your opinion or expectation out

Re: [HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-07 Thread Amit Kapila
On Tue, Nov 5, 2013 at 3:20 PM, Rajeev rastogi rajeev.rast...@huawei.com wrote: On execution of pg_resetxlog using the option -n 1. It will display values in two section. 2. First section will be called as Current pg_control values or Guess pg_control values.

[HACKERS] TODO: Split out pg_resetxlog output into pre- and post-sections

2013-11-05 Thread Rajeev rastogi
This patch implements the following TODO item: Split out pg_resetxlog output into pre- and post-sections http://archives.postgresql.org/pgsql-hackers/2010-08/msg02040.php On execution of pg_resetxlog using the option -n 1. It will