[HACKERS] Thread code not vpath-safe

2004-04-26 Thread Alvaro Herrera
The thread testing program is not nice to a vpath build.  I see this
error:

checking for gmake... gmake
checking thread safety of required library functions... Makefile:13: 
../../../src/Makefile.global: No such file or directory
gmake: *** No rule to make target `../../../src/Makefile.global'.  Stop.
configure: error: Can not clean thread test directory.

(Basically what I'm doing is create an empty directory, cd to it and
then call ../sourcedir/configure --enable-thread-safety)

-- 
Alvaro Herrera (alvherre[a]dcc.uchile.cl)
Por suerte hoy explotó el califont porque si no me habría muerto
de aburrido  (Papelucho)

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


Re: [HACKERS] Thread code not vpath-safe

2004-04-26 Thread Alvaro Herrera
On Mon, Apr 26, 2004 at 01:15:13PM -0400, Bruce Momjian wrote:
 Alvaro Herrera wrote:
  The thread testing program is not nice to a vpath build.  I see this
  error:

  (Basically what I'm doing is create an empty directory, cd to it and
  then call ../sourcedir/configure --enable-thread-safety)
 
 I tried and couldn't get it to fail.

Whoa, seems I'm the irreproducible-bug-reporter now :-(

 Do you have this line at the bottom of configure.in:
 
   if ! $srcdir/src/tools/thread/thread_test 5

Yes:

if ! $srcdir/src/tools/thread/thread_test 5
thenrm -f $srcdir/src/Makefile.global
echo no
echo
$srcdir/src/tools/thread/thread_test
echo
AC_MSG_ERROR([Thread test program failed.  Your platform is not thread-safe.])
fi


I tried it with:

mkdir /tmp/thr
cd /tmp/thr
~/CVS/pgsql/source/00orig/configure --enable-thread-safety

[lots of output, and then:]
checking for gmake... gmake
checking thread safety of required library functions... Makefile:13: 
../../../src/Makefile.global: No such file or directory
gmake: *** No rule to make target `../../../src/Makefile.global'.  Stop.
configure: error: Can not clean thread test directory.

-- 
Alvaro Herrera (alvherre[a]dcc.uchile.cl)
No necesitamos banderas
No reconocemos fronteras  (Jorge González)

---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html


Re: [HACKERS] Thread code not vpath-safe

2004-04-26 Thread Bruce Momjian
Alvaro Herrera wrote:
 The thread testing program is not nice to a vpath build.  I see this
 error:
 
 checking for gmake... gmake
 checking thread safety of required library functions... Makefile:13: 
 ../../../src/Makefile.global: No such file or directory
 gmake: *** No rule to make target `../../../src/Makefile.global'.  Stop.
 configure: error: Can not clean thread test directory.
 
 (Basically what I'm doing is create an empty directory, cd to it and
 then call ../sourcedir/configure --enable-thread-safety)

I tried and couldn't get it to fail.  Do you have this line at the
bottom of configure.in:

if ! $srcdir/src/tools/thread/thread_test 5

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings


Re: [HACKERS] Thread code not vpath-safe

2004-04-26 Thread Bruce Momjian

OK, I worked with Alvaro via IM and it is fixed now.

---

Alvaro Herrera wrote:
 On Mon, Apr 26, 2004 at 01:15:13PM -0400, Bruce Momjian wrote:
  Alvaro Herrera wrote:
   The thread testing program is not nice to a vpath build.  I see this
   error:
 
   (Basically what I'm doing is create an empty directory, cd to it and
   then call ../sourcedir/configure --enable-thread-safety)
  
  I tried and couldn't get it to fail.
 
 Whoa, seems I'm the irreproducible-bug-reporter now :-(
 
  Do you have this line at the bottom of configure.in:
  
  if ! $srcdir/src/tools/thread/thread_test 5
 
 Yes:
 
 if ! $srcdir/src/tools/thread/thread_test 5
 thenrm -f $srcdir/src/Makefile.global
 echo no
 echo
 $srcdir/src/tools/thread/thread_test
 echo
 AC_MSG_ERROR([Thread test program failed.  Your platform is not 
 thread-safe.])
 fi
 
 
 I tried it with:
 
 mkdir /tmp/thr
 cd /tmp/thr
 ~/CVS/pgsql/source/00orig/configure --enable-thread-safety
 
 [lots of output, and then:]
 checking for gmake... gmake
 checking thread safety of required library functions... Makefile:13: 
 ../../../src/Makefile.global: No such file or directory
 gmake: *** No rule to make target `../../../src/Makefile.global'.  Stop.
 configure: error: Can not clean thread test directory.
 
 -- 
 Alvaro Herrera (alvherre[a]dcc.uchile.cl)
 No necesitamos banderas
 No reconocemos fronteras  (Jorge Gonz?lez)
 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


Re: [HACKERS] Thread code not vpath-safe

2004-04-26 Thread Alvaro Herrera
On Mon, Apr 26, 2004 at 03:09:48PM -0400, Bruce Momjian wrote:
 
 OK, I worked with Alvaro via IM and it is fixed now.

It worked cleanly for me.  Thanks.

Also, the thread flags look correct, but then I'm not a threaded
person.

-- 
Alvaro Herrera (alvherre[a]dcc.uchile.cl)
Tiene valor aquel que admite que es un cobarde (Fernandel)

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly