Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

> Although this error message is not wrong, I think it should be better > to > give error message as "invalid input syntax for type int" for "7.a". > This could be done by delete "return false;" after "while(...)", let > the following if to decide which to return. Ah, now I understand. Sorry, I

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

Hi, I found the last commit changed as: ``` /* skip invalid characters */ do { (*scan_length)++; - } while (**scan_length != ' ' && **scan_length != '\0' && isdigit(**scan_length)); + } while (isdigit(**scan_length)); return

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

> I am afraid the changes may separate "7.a" to "7" and "a", then error > out > with "invalid input syntax for type int" for "a". Which is correct, is it not? > How about changes as below? (use following the if to decide true or > false) > ... >return false; > +} while

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

Diff from the head: (use the following if to decide true or false) ``` diff --git a/src/interfaces/ecpg/ecpglib/data.c b/src/interfaces/ecpg/ecpglib/data.c index 5375934..1621e7b 100644 --- a/src/interfaces/ecpg/ecpglib/data.c +++ b/src/interfaces/ecpg/ecpglib/data.c @@ -57,8 +57,7 @@

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

Thanks for commit. I am afraid the changes may separate "7.a" to "7" and "a", then error out with "invalid input syntax for type int" for "a". How about changes as below? (use following the if to decide true or false) ``` -} while (**scan_length != ' ' && **scan_length != '\0'); -

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

> Any comments? Sorry, I've been working through the backlog of three weeks of traveling. > > I tried some tests with ecpg informix mode. > > When trying to store float data into a integer var, I got endless > > loop. > > > > The reason is: > > In informix mode, ecpg can accept > > string form

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

On Wed, Nov 1, 2017 at 12:22 PM, 高增琦 wrote: > Any comments? > Hi, You should register these patches for the next commitfest at https://commitfest.postgresql.org/15/. As Michael pointed out earlier, this commitfest will start soon so you should add your patches quickly.

Re: [HACKERS] Try to fix endless loop in ecpg with informix mode

Any comments? 2017-10-26 16:03 GMT+08:00 高增琦 : > Hi, > > I tried some tests with ecpg informix mode. > When trying to store float data into a integer var, I got endless loop. > > The reason is: > In informix mode, ecpg can accept > string form of float number when processing

[HACKERS] Try to fix endless loop in ecpg with informix mode

Hi, I tried some tests with ecpg informix mode. When trying to store float data into a integer var, I got endless loop. The reason is: In informix mode, ecpg can accept string form of float number when processing query result. During checking the string form of float number, it seems that ecpg