On 2017/08/04 1:52, Robert Haas wrote:
On Thu, Aug 3, 2017 at 5:55 AM, Etsuro Fujita
wrote:
I updated the patch that way. Attached is a new version of the patch.
Committed.
Thanks again.
Best regards,
Etsuro Fujita
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
T
On Thu, Aug 3, 2017 at 5:55 AM, Etsuro Fujita
wrote:
> I updated the patch that way. Attached is a new version of the patch.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql
On 2017/08/02 4:07, Robert Haas wrote:
On Tue, Aug 1, 2017 at 12:31 AM, Etsuro Fujita
wrote:
Maybe I'm missing something, but I'm not sure that's a good idea because the
change says like we might have 'wholerow' only for the FDW case, but that
isn't correct because we would have 'wholerow' for
On Tue, Aug 1, 2017 at 12:31 AM, Etsuro Fujita
wrote:
> Maybe I'm missing something, but I'm not sure that's a good idea because the
> change says like we might have 'wholerow' only for the FDW case, but that
> isn't correct because we would have 'wholerow' for a view as well. ISTM that
> views sh
On 2017/08/01 1:03, Robert Haas wrote:
On Fri, Jul 28, 2017 at 8:12 AM, Etsuro Fujita
wrote:
On 2017/07/26 22:39, Robert Haas wrote:
So the first part of the change weakens the assertion that a 'ctid' or
'wholerow' attribute will always be present by saying that an FDW may
instead have other a
On Fri, Jul 28, 2017 at 8:12 AM, Etsuro Fujita
wrote:
> On 2017/07/26 22:39, Robert Haas wrote:
>> So the first part of the change weakens the assertion that a 'ctid' or
>> 'wholerow' attribute will always be present by saying that an FDW may
>> instead have other attributes sufficient to identify
On 2017/07/26 22:39, Robert Haas wrote:
On Wed, Jun 14, 2017 at 10:40 PM, Etsuro Fujita
wrote:
Attached is an updated version of the patch.
Well, now I'm confused:
* Initialize the junk filter(s) if needed. INSERT queries need a filter
* if there are any junk attrs in the tlis
On Wed, Jun 14, 2017 at 10:40 PM, Etsuro Fujita
wrote:
> Agreed, but I think it's better to add that detail to this comment in
> ExecInitModifyTable:
>
> * Initialize the junk filter(s) if needed. INSERT queries need a
> filter
> * if there are any junk attrs in the tlist. UPDATE and D
On 2017/06/07 0:30, Robert Haas wrote:
On Mon, Jun 5, 2017 at 4:45 AM, Etsuro Fujita
wrote:
While working on [1], I noticed that the comment in ExecModifyTable:
* Foreign table updates have a wholerow attribute when the
* relation has an AFTER ROW trigger.
On Mon, Jun 5, 2017 at 4:45 AM, Etsuro Fujita
wrote:
> While working on [1], I noticed that the comment in ExecModifyTable:
>
> * Foreign table updates have a wholerow attribute when the
> * relation has an AFTER ROW trigger.
>
> is not 100% correct because a fore
While working on [1], I noticed that the comment in ExecModifyTable:
* Foreign table updates have a wholerow attribute when the
* relation has an AFTER ROW trigger.
is not 100% correct because a foreign table has a wholerow attrubute
when the relation has an AF
11 matches
Mail list logo