On Tue, Aug 26, 2014 at 4:10 AM, Michael Paquier
wrote:
>
> On Tue, Aug 26, 2014 at 3:48 AM, Heikki Linnakangas
> wrote:
> > AFAICS, the namespace can never be NULL in any of these. There is a
> > "selectSourceSchema(fout, tbinfo->dobj.namespace->dobj.name)" call
before or
> > after printing the
On 08/26/2014 10:10 AM, Michael Paquier wrote:
On Tue, Aug 26, 2014 at 3:48 AM, Heikki Linnakangas
wrote:
AFAICS, the namespace can never be NULL in any of these. There is a
"selectSourceSchema(fout, tbinfo->dobj.namespace->dobj.name)" call before or
after printing the message, so if tbinfo->do
On Tue, Aug 26, 2014 at 3:48 AM, Heikki Linnakangas
wrote:
> AFAICS, the namespace can never be NULL in any of these. There is a
> "selectSourceSchema(fout, tbinfo->dobj.namespace->dobj.name)" call before or
> after printing the message, so if tbinfo->dobj.namespace is NULL, you'll
> crash anyway.
On 08/20/2014 11:11 PM, Fabrízio de Royes Mello wrote:
On Wed, Aug 20, 2014 at 2:43 AM, Michael Paquier
wrote:
I had a look at this patch, and here are a couple of comments:
1) Depending on how ArchiveEntry is called to register an object to
dump, namespace may be NULL, but it is not the case
On Wed, Aug 20, 2014 at 8:24 PM, Michael Paquier
wrote:
>
> On Thu, Aug 21, 2014 at 5:11 AM, Fabrízio de Royes Mello
> wrote:
> > I just change "if (tbinfo->dobj.namespace != NULL)" to "if
> > (tbinfo->dobj.namespace)".
> Fine for me. I am marking this patch as ready for committer.
>
Thanks!
--
On Thu, Aug 21, 2014 at 5:11 AM, Fabrízio de Royes Mello
wrote:
> I just change "if (tbinfo->dobj.namespace != NULL)" to "if
> (tbinfo->dobj.namespace)".
Fine for me. I am marking this patch as ready for committer.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
On Wed, Aug 20, 2014 at 2:43 AM, Michael Paquier
wrote:
>
> I had a look at this patch, and here are a couple of comments:
> 1) Depending on how ArchiveEntry is called to register an object to
> dump, namespace may be NULL, but it is not the case
> namespace->dobj.name, so you could get the namesp
On Fri, Jul 25, 2014 at 4:45 AM, Fabrízio de Royes Mello
wrote:
>
> Given this is a very small and simple patch I thought it's not necessary...
>
> Added to the next CommitFest.
I had a look at this patch, and here are a couple of comments:
1) Depending on how ArchiveEntry is called to register a
On Thu, Jul 24, 2014 at 4:36 PM, Robert Haas wrote:
>
> On Wed, Jul 23, 2014 at 5:48 PM, Fabrízio de Royes Mello
> wrote:
> >
> > On Thu, Apr 17, 2014 at 9:15 PM, Michael Paquier <
michael.paqu...@gmail.com>
> > wrote:
> >>
> >> On Fri, Apr 18, 2014 at 4:29 AM, Fabrízio de Royes Mello
> >> wrote
On Wed, Jul 23, 2014 at 5:48 PM, Fabrízio de Royes Mello
wrote:
>
> On Thu, Apr 17, 2014 at 9:15 PM, Michael Paquier
> wrote:
>>
>> On Fri, Apr 18, 2014 at 4:29 AM, Fabrízio de Royes Mello
>> wrote:
>> >
>> > On Thu, Apr 17, 2014 at 12:46 PM, Bruce Momjian
>> > wrote:
>> >>
>> >> On Thu, Apr 17
On Thu, Apr 17, 2014 at 9:15 PM, Michael Paquier
wrote:
>
> On Fri, Apr 18, 2014 at 4:29 AM, Fabrízio de Royes Mello
> wrote:
> >
> > On Thu, Apr 17, 2014 at 12:46 PM, Bruce Momjian
wrote:
> >>
> >> On Thu, Apr 17, 2014 at 11:44:37AM -0400, Tom Lane wrote:
> >> > Bruce Momjian writes:
> >> > >
On Fri, Apr 18, 2014 at 4:29 AM, Fabrízio de Royes Mello
wrote:
>
> On Thu, Apr 17, 2014 at 12:46 PM, Bruce Momjian wrote:
>>
>> On Thu, Apr 17, 2014 at 11:44:37AM -0400, Tom Lane wrote:
>> > Bruce Momjian writes:
>> > > The idea is that we only need quotes when there are odd characters in
>> >
On Thu, Apr 17, 2014 at 12:46 PM, Bruce Momjian wrote:
>
> On Thu, Apr 17, 2014 at 11:44:37AM -0400, Tom Lane wrote:
> > Bruce Momjian writes:
> > > The idea is that we only need quotes when there are odd characters in
> > > the identifier. We do that right now in some places, though I can't
> >
On Thu, Apr 17, 2014 at 11:44:37AM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > The idea is that we only need quotes when there are odd characters in
> > the identifier. We do that right now in some places, though I can't
> > find them in pg_dump. I know psql does that, see quote_ident().
Bruce Momjian writes:
> The idea is that we only need quotes when there are odd characters in
> the identifier. We do that right now in some places, though I can't
> find them in pg_dump. I know psql does that, see quote_ident().
I think our general style rule is that identifiers embedded in me
On Thu, Apr 17, 2014 at 12:07:39PM -0300, Fabrízio de Royes Mello wrote:
> > Can you get that to _conditionally_ double-quote the strings?
>
> Sorry, I didn't understand what you means? Your idea is to check if the
> namespace is available and then don't show the double-quote, is that?
The idea
On Thu, Apr 17, 2014 at 11:36 AM, Bruce Momjian wrote:
>
> On Thu, Apr 17, 2014 at 11:29:03AM -0300, Fabrízio de Royes Mello wrote:
> > > > This database have a lot of different schemas with same structure
and if I
> > > > need do view the status of dump I don't know what schema the table
are dump
On Thu, Apr 17, 2014 at 11:29:03AM -0300, Fabrízio de Royes Mello wrote:
> > > This database have a lot of different schemas with same structure and if I
> > > need do view the status of dump I don't know what schema the table are
> > > dump
> > > from.
> > Yes this may be helpful. The attached qu
On Thu, Apr 17, 2014 at 2:14 AM, Michael Paquier
wrote:
>
> On Thu, Apr 17, 2014 at 11:41 AM, Fabrízio de Royes Mello
> wrote:
> > Hi all,
> >
> > There are some reason to verbose output of pg_dump don't show schema
name?
> >
> > A output example of using "pg_dump -Fd -j8 -v"
> Specifying a targe
On Thu, Apr 17, 2014 at 11:41 AM, Fabrízio de Royes Mello
wrote:
> Hi all,
>
> There are some reason to verbose output of pg_dump don't show schema name?
>
> A output example of using "pg_dump -Fd -j8 -v"
Specifying a target directory with "-f" is better here...
> This database have a lot of diff
Hi all,
There are some reason to verbose output of pg_dump don't show schema name?
A output example of using "pg_dump -Fd -j8 -v"
...
pg_dump: dumping contents of table geocoordinate
pg_dump: dumping contents of table historyvalue
pg_dump: dumping contents of table historyvalue
pg_dump: dumping
21 matches
Mail list logo
