Re: [HACKERS] contrib/pg_visibility craps out in assert-enabled builds

2016-10-03 Thread Tom Lane
Robert Haas writes: > On Fri, Sep 30, 2016 at 10:24 PM, Tom Lane wrote: >> The problem seems to be that HeapTupleSatisfiesVacuum asserts >> Assert(ItemPointerIsValid(&htup->t_self)); >> while collect_corrupt_items hasn't bothered to set up the t_self >> field of the HeapTupleData it's passing in.

Re: [HACKERS] contrib/pg_visibility craps out in assert-enabled builds

2016-10-03 Thread Robert Haas
On Fri, Sep 30, 2016 at 10:24 PM, Tom Lane wrote: > So I tried using pg_visibility's pg_check_visible() as part of > testing the business with pg_upgrade generating faulty visibility > maps on bigendian servers, and it instantly generated an assert > failure here: > > #2 0x0041de78 in Exceptional

[HACKERS] contrib/pg_visibility craps out in assert-enabled builds

2016-09-30 Thread Tom Lane
So I tried using pg_visibility's pg_check_visible() as part of testing the business with pg_upgrade generating faulty visibility maps on bigendian servers, and it instantly generated an assert failure here: #2 0x0041de78 in ExceptionalCondition (conditionName=, errorType=, fileName=, lineNumber=)