Re: [HACKERS] heap_update() VM retry could break HOT?

2016-07-18 Thread Pavan Deolasee
On Mon, Jul 18, 2016 at 12:47 PM, Andres Freund wrote: > > as far as I can see that could mean that we perform hot updates when not > permitted, because the tuple has been replaced since, including the > pkey. Similarly, the wrong tuple lock mode could end up being used. > > Am I missing somethin

[HACKERS] heap_update() VM retry could break HOT?

2016-07-18 Thread Andres Freund
Hi, heap_update() retries pinning the vm pinning, as explained in the following comment: /* * Before locking the buffer, pin the visibility map page if it appears to * be necessary. Since we haven't got the lock yet, someone else might be * in the middle of c