Re: [HACKERS] merging duplicate definitions of adjust_relid_set

2017-03-17 Thread Robert Haas
On Fri, Mar 17, 2017 at 1:50 PM, Tom Lane wrote: > Robert Haas writes: >> While reviewing Ashutosh Bapat's partitionwise join code, I noticed >> he'd run up against the problem that adjust_relid_set() is defined as >> static in two different source files, and he wanted to call it from a >> third

Re: [HACKERS] merging duplicate definitions of adjust_relid_set

2017-03-17 Thread Tom Lane
Robert Haas writes: > While reviewing Ashutosh Bapat's partitionwise join code, I noticed > he'd run up against the problem that adjust_relid_set() is defined as > static in two different source files, and he wanted to call it from a > third file. I didn't much like his solution to that problem,

[HACKERS] merging duplicate definitions of adjust_relid_set

2017-03-17 Thread Robert Haas
While reviewing Ashutosh Bapat's partitionwise join code, I noticed he'd run up against the problem that adjust_relid_set() is defined as static in two different source files, and he wanted to call it from a third file. I didn't much like his solution to that problem, which was to rename one of th