On Fri, Sep 15, 2017 at 9:20 PM, Robert Haas wrote:
> On Thu, Sep 14, 2017 at 8:30 AM, Ashutosh Bapat
> wrote:
>> LGTM. The patch applies cleanly on the current HEAD, compiles (small
>> bit in regress.c requires compilation), and make check passes. Marking
>> this as "ready for committer".
>
> Co
On Thu, Sep 14, 2017 at 8:30 AM, Ashutosh Bapat
wrote:
> LGTM. The patch applies cleanly on the current HEAD, compiles (small
> bit in regress.c requires compilation), and make check passes. Marking
> this as "ready for committer".
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb
On Wed, Sep 13, 2017 at 1:46 PM, Amit Langote
wrote:
>>
>> Ok. May be then create_function_1.sql is the right place. Just add it
>> to the section of passing tests and annotate that it's testing
>> creating an FDW handler. Sorry for jumping back and forth.
>
> Alright, done. Thanks for reviewing.
On 2017/09/13 16:59, Ashutosh Bapat wrote:
> On Wed, Sep 13, 2017 at 1:27 PM, Amit Langote
> wrote:
>> On 2017/09/13 16:42, Ashutosh Bapat wrote:
>>> On Wed, Sep 13, 2017 at 7:49 AM, Amit Langote wrote:
In the attached updated patch, I created separate .source files in
src/test/regress/i
On Wed, Sep 13, 2017 at 1:27 PM, Amit Langote
wrote:
> On 2017/09/13 16:42, Ashutosh Bapat wrote:
>> On Wed, Sep 13, 2017 at 7:49 AM, Amit Langote wrote:
>>> In the attached updated patch, I created separate .source files in
>>> src/test/regress/input and output directories called fdw_handler.sour
On 2017/09/13 16:42, Ashutosh Bapat wrote:
> On Wed, Sep 13, 2017 at 7:49 AM, Amit Langote wrote:
>> In the attached updated patch, I created separate .source files in
>> src/test/regress/input and output directories called fdw_handler.source
>> and put the test_fdw_handler function definition ther
On Wed, Sep 13, 2017 at 7:49 AM, Amit Langote
wrote:
> On 2017/09/12 20:17, Ashutosh Bapat wrote:
>> On Tue, Sep 12, 2017 at 2:27 PM, Amit Langote
>> wrote:
>>> Thanks Ashutosh for taking a look at this.
>>>
>>> On 2017/09/05 21:16, Ashutosh Bapat wrote:
The patch needs a rebase.
>>>
>>> Att
On 2017/09/12 20:17, Ashutosh Bapat wrote:
> On Tue, Sep 12, 2017 at 2:27 PM, Amit Langote
> wrote:
>> Thanks Ashutosh for taking a look at this.
>>
>> On 2017/09/05 21:16, Ashutosh Bapat wrote:
>>> The patch needs a rebase.
>>
>> Attached rebased patch.
>
> Thanks for rebased patch.
Thanks for
On Tue, Sep 12, 2017 at 2:27 PM, Amit Langote
wrote:
> Thanks Ashutosh for taking a look at this.
>
> On 2017/09/05 21:16, Ashutosh Bapat wrote:
>> The patch needs a rebase.
>
> Attached rebased patch.
Thanks for rebased patch.
We could annotate each ERROR with an explanation as to why that's an
Thanks Ashutosh for taking a look at this.
On 2017/09/05 21:16, Ashutosh Bapat wrote:
> The patch needs a rebase.
Attached rebased patch.
Thanks,
Amit
From 75bcb6ebcc00193cb0251fced994f03d205e9e7f Mon Sep 17 00:00:00 2001
From: amit
Date: Wed, 10 May 2017 10:37:42 +0900
Subject: [PATCH] Add som
On Wed, May 10, 2017 at 5:55 AM, Amit Langote
wrote:
> On 2017/05/09 22:52, Mark Dilger wrote:
>>
>>> On May 9, 2017, at 12:18 AM, Amit Langote
>>> wrote:
>>>
>>> Hi,
>>>
>>> On 2017/05/05 9:38, Mark Dilger wrote:
Hackers,
just FYI, I cannot find any regression test coverage of th
On 2017/05/09 22:52, Mark Dilger wrote:
>
>> On May 9, 2017, at 12:18 AM, Amit Langote
>> wrote:
>>
>> Hi,
>>
>> On 2017/05/05 9:38, Mark Dilger wrote:
>>> Hackers,
>>>
>>> just FYI, I cannot find any regression test coverage of this part of the
>>> grammar, not
>>> even in the contrib/ directo
> On May 9, 2017, at 12:18 AM, Amit Langote
> wrote:
>
> Hi,
>
> On 2017/05/05 9:38, Mark Dilger wrote:
>> Hackers,
>>
>> just FYI, I cannot find any regression test coverage of this part of the
>> grammar, not
>> even in the contrib/ directory or TAP tests. I was going to submit a patch
>
On Tue, May 9, 2017 at 12:48 PM, Amit Langote
wrote:
> Hi,
>
> On 2017/05/05 9:38, Mark Dilger wrote:
>> Hackers,
>>
>> just FYI, I cannot find any regression test coverage of this part of the
>> grammar, not
>> even in the contrib/ directory or TAP tests. I was going to submit a patch
>> to he
Hi,
On 2017/05/05 9:38, Mark Dilger wrote:
> Hackers,
>
> just FYI, I cannot find any regression test coverage of this part of the
> grammar, not
> even in the contrib/ directory or TAP tests. I was going to submit a patch
> to help out,
> and discovered it is not so easy to do, and perhaps th
On Fri, May 5, 2017 at 6:08 AM, Mark Dilger wrote:
> Hackers,
>
> just FYI, I cannot find any regression test coverage of this part of the
> grammar, not
> even in the contrib/ directory or TAP tests. I was going to submit a patch
> to help out,
> and discovered it is not so easy to do, and per
Hackers,
just FYI, I cannot find any regression test coverage of this part of the
grammar, not
even in the contrib/ directory or TAP tests. I was going to submit a patch to
help out,
and discovered it is not so easy to do, and perhaps that is why the coverage is
missing.
My apologies for the
17 matches
Mail list logo
