Re: [HACKERS] patch to fix unused variable warning on windows build

2013-11-13 Thread Peter Eisentraut
On Thu, 2013-11-07 at 19:13 +1300, David Rowley wrote: > Attached is a small patch which fixes the unused variable warning in > the visual studios build. Seems like VS does not > support __attribute__((unused)) but looks like all other places we > must assign to the variable. > committed --

Re: [HACKERS] patch to fix unused variable warning on windows build

2013-11-09 Thread Amit Kapila
On Sat, Nov 9, 2013 at 1:00 PM, David Rowley wrote: > On Sat, Nov 9, 2013 at 7:29 PM, Amit Kapila wrote: >> > Thanks for the link. > The reason that we don't see more warnings for this is that it seems in all > other places where we have used PG_USED_FOR_ASSERTS_ONLY, the variable is > getting as

Re: [HACKERS] patch to fix unused variable warning on windows build

2013-11-08 Thread David Rowley
On Sat, Nov 9, 2013 at 7:29 PM, Amit Kapila wrote: > On Thu, Nov 7, 2013 at 11:43 AM, David Rowley > wrote: > > Attached is a small patch which fixes the unused variable warning in the > > visual studios build. Seems like VS does not support > > __attribute__((unused)) but looks like all other p

Re: [HACKERS] patch to fix unused variable warning on windows build

2013-11-08 Thread Amit Kapila
On Thu, Nov 7, 2013 at 11:43 AM, David Rowley wrote: > Attached is a small patch which fixes the unused variable warning in the > visual studios build. Seems like VS does not support > __attribute__((unused)) but looks like all other places we must assign to > the variable. I have raised same iss

[HACKERS] patch to fix unused variable warning on windows build

2013-11-06 Thread David Rowley
Attached is a small patch which fixes the unused variable warning in the visual studios build. Seems like VS does not support __attribute__((unused)) but looks like all other places we must assign to the variable. Regards David Rowley unused_variable.patch Description: Binary data -- Sent vi