Re: [HACKERS] pg_dump -s -b

2016-11-19 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > IMO, blobs are data, so those behaviors are correct. The docs should > be fixed to match the code. Works for me. Thoughts on the attached? Thanks! Stephen diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml new file mode 100644 in

Re: [HACKERS] pg_dump -s -b

2016-11-19 Thread Tom Lane
Stephen Frost writes: > To wit, our docs specifically say: > > Include large objects in the dump. This is the default behavior except > when --schema, --table, or --schema-only is specified, so the -b switch > is only useful to add large objects to selective dumps. > Clearly, this is an

[HACKERS] pg_dump -s -b

2016-11-19 Thread Stephen Frost
All, While reviewing and considering the patch to add the --no-blobs option to pg_dump, which I entirely agree with, I came across our claim that passing -b to pg_dump would cause blobs to be output, regardless of other options set. To wit, our docs specifically say: Include large objects i