[HACKERS] psql source suggestions

2003-02-12 Thread Jeroen T. Vermeulen
I've been playing around with the source for psql, and as a result I
did some cleaning up in common.c.  Would anyone be interested in seeing
patches for that?  The main benefit is some eliminated code duplication,
plus the removal of some warts like 'continue' and 'break' where they
weren't needed.


Jeroen


---(end of broadcast)---
TIP 6: Have you searched our list archives?

http://archives.postgresql.org



Re: [HACKERS] psql source suggestions

2003-02-12 Thread Tom Lane
Jeroen T. Vermeulen [EMAIL PROTECTED] writes:
 I've been playing around with the source for psql, and as a result I
 did some cleaning up in common.c.  Would anyone be interested in seeing
 patches for that?  The main benefit is some eliminated code duplication,
 plus the removal of some warts like 'continue' and 'break' where they
 weren't needed.

Sure, send it along to pgsql-patches.  Code beautification is a
worthwhile goal that we spend far too little time on.

Of course, beauty is in the eye of the beholder, so there may not be
universal agreement that you made improvements ;-).  But send 'em along
and then we can debate the point.

regards, tom lane

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly



Re: [HACKERS] psql source suggestions

2003-02-12 Thread Bruce Momjian

Sure.  Shoot them over.

---

Jeroen T. Vermeulen wrote:
 I've been playing around with the source for psql, and as a result I
 did some cleaning up in common.c.  Would anyone be interested in seeing
 patches for that?  The main benefit is some eliminated code duplication,
 plus the removal of some warts like 'continue' and 'break' where they
 weren't needed.
 
 
 Jeroen
 
 
 ---(end of broadcast)---
 TIP 6: Have you searched our list archives?
 
 http://archives.postgresql.org
 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly