Re: [HACKERS] Small typo in pageinspect heapfuncs

On 10/26/2016 09:52 AM, Daniel Gustafsson wrote: Spotted a tiny typo in contrib/pageinspect/heapfuncs.c: s/accordindly/accordingly/ Fixed, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Small typo in pageinspect heapfuncs

Spotted a tiny typo in contrib/pageinspect/heapfuncs.c: s/accordindly/accordingly/ cheers ./daniel typo-pageinspect_heapfuncs.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Small typo in a comment in pg_regress.c

Andreas, * Andreas 'ads' Scherbaum (adsm...@wars-nicht.de) wrote: > stumbled over this while looking into the source. Patch attached. Fix pushed, thanks! Stephen signature.asc Description: Digital signature

[HACKERS] Small typo in a comment in pg_regress.c

Hi, stumbled over this while looking into the source. Patch attached. Regards, -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of Directors Volunteer Regional Contact, Germany - PostgreSQL Project diff --git

Re: [HACKERS] Small typo in timeline.h regarding the meaning of infinity for timeline history entry

On Tue, Sep 15, 2015 at 7:38 AM, Fujii Masao wrote: > Thanks for the report and patch! Applied. Thanks! -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Small typo in timeline.h regarding the meaning of infinity for timeline history entry

On Thu, Sep 10, 2015 at 2:37 PM, Michael Paquier wrote: > Hi all, > > timeline.h quotes that the end point of timeline history entry means > infinity when its value is 0. But that's not completely true, I think > that what is meant here is InvalidXLogRecPtr: > { >

[HACKERS] Small typo in timeline.h regarding the meaning of infinity for timeline history entry

Hi all, timeline.h quotes that the end point of timeline history entry means infinity when its value is 0. But that's not completely true, I think that what is meant here is InvalidXLogRecPtr: { TimeLineID tli; XLogRecPtr begin; /* inclusive */ -

Re: [HACKERS] small typo

On 05/20/2015 06:55 AM, Euler Taveira wrote: Attached is a small typo. Fixed, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] small typo

Hi, Attached is a small typo. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento diff --git a/contrib/pg_buffercache/pg_buffercache_pages.c b/contrib/pg_buffercache/pg_buffercache_pages.c index

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

Bruce Momjian br...@momjian.us writes: On Mon, Jul 22, 2013 at 07:32:20PM -0400, Tom Lane wrote: We could for instance keep the high half as tv_sec, while making the low half be something like (tv_usec 12) | (getpid() 0xfff). This would restore the intended ability to reverse-engineer the

Re: [HACKERS] small typo about comment in xlog.c

On 04/10/2014 07:19 AM, Tomonari Katsumata wrote: Hi, I'm reading xlog.c, and I noticed a comment of do_pg_abort_backup is typo. ... 10247 * NB: This is only for aborting a non-exclusive backup that doesn't write 10248 * backup_label. A backup started with pg_stop_backup() needs to be

[HACKERS] small typo about comment in xlog.c

Hi, I'm reading xlog.c, and I noticed a comment of do_pg_abort_backup is typo. ... 10247 * NB: This is only for aborting a non-exclusive backup that doesn't write 10248 * backup_label. A backup started with pg_stop_backup() needs to be finished 10249 * with pg_stop_backup(). ... I think A

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

On Mon, Jul 22, 2013 at 07:32:20PM -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-07-22 15:55:46 -0400, Robert Haas wrote: And why is that? The comment above tells: while the lower half is the XOR of tv_sec and tv_usec. Yeah, the code doesn't match the

[HACKERS] small typo in src/backend/access/transam/xlog.c

Hi in void BootStrapXLOG(void) * to seed it other than the system clock value...) The upper half of the * uint64 value is just the tv_sec part, while the lower half is the XOR * of tv_sec and tv_usec. This is to ensure that we don't lose uniqueness *

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

On Mon, Jul 22, 2013 at 6:45 AM, didier did...@gmail.com wrote: Hi in void BootStrapXLOG(void) * to seed it other than the system clock value...) The upper half of the * uint64 value is just the tv_sec part, while the lower half is the XOR * of tv_sec and

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

On 2013-07-22 15:55:46 -0400, Robert Haas wrote: On Mon, Jul 22, 2013 at 6:45 AM, didier did...@gmail.com wrote: Hi in void BootStrapXLOG(void) * to seed it other than the system clock value...) The upper half of the * uint64 value is just the tv_sec part, while

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

Andres Freund and...@2ndquadrant.com writes: On 2013-07-22 15:55:46 -0400, Robert Haas wrote: And why is that? The comment above tells: while the lower half is the XOR of tv_sec and tv_usec. Yeah, the code doesn't match the comment; this mistake seems to be aboriginal. I don't think it

[HACKERS] Small typo in syncrep.h

Hello, While reading code, I noticed a small typo in syncrep.h. It says SyncRepUpdateSyncStandbysDefined() is called by wal writer whereas its called by the checkpointer process, at least in the HEAD. Previously, it was being called by the bgwriter process. Attached patches fix this in the

Re: [HACKERS] Small typo in syncrep.h

On Thu, May 23, 2013 at 4:44 AM, Pavan Deolasee pavan.deola...@gmail.com wrote: While reading code, I noticed a small typo in syncrep.h. It says SyncRepUpdateSyncStandbysDefined() is called by wal writer whereas its called by the checkpointer process, at least in the HEAD. Previously, it was