Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-20 Thread Tom Lane
Michael Paquier writes: > On Wed, Sep 20, 2017 at 12:33 AM, Tom Lane wrote: >> That would indicate that something isn't ever retrying the worker >> start; but if that's the case, how is it that we get through the >> other subscription tests with my

Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-19 Thread Michael Paquier
On Wed, Sep 20, 2017 at 12:33 AM, Tom Lane wrote: > That would indicate that something isn't ever retrying the worker > start; but if that's the case, how is it that we get through the > other subscription tests with my random-failure patch in place? I have been able to dig

Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-19 Thread Tom Lane
Michael Paquier writes: > Now, I just had a look at the logs for a failure and a success, and > one difference can be seen in the subscriber's logs as follows: > -LOG: logical replication table synchronization worker for > subscription "mysub", table "test1" has

Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-19 Thread Michael Paquier
On Tue, Sep 19, 2017 at 8:51 PM, Robert Haas wrote: > On Mon, Sep 18, 2017 at 1:58 PM, Andres Freund wrote: >> To my knowledge here's not really any difference between the two in >> logical replication. Received changes are immediately applied, there's

Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-19 Thread Robert Haas
On Mon, Sep 18, 2017 at 1:58 PM, Andres Freund wrote: > To my knowledge here's not really any difference between the two in > logical replication. Received changes are immediately applied, there's > no equivalent to a walreceiver queing up "logical wal" onto disk. Huh?

Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-18 Thread Tom Lane
Andres Freund writes: > On 2017-09-18 11:50:06 -0400, Tom Lane wrote: >> The reason seems to be that its method of waiting for replication >> to happen is completely inapropos. It's watching for the master >> to say that the slave has received all the WAL, but that does not

Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-18 Thread Andres Freund
Hi, On 2017-09-18 11:50:06 -0400, Tom Lane wrote: > The reason seems to be that its method of waiting for replication > to happen is completely inapropos. It's watching for the master > to say that the slave has received all the WAL, but that does not > ensure that the logicalrep apply workers

[HACKERS] src/test/subscription/t/005_encoding.pl is broken

2017-09-18 Thread Tom Lane
To reproduce the subscription-startup hang that Thomas Munro observed, I changed src/backend/replication/logical/launcher.c like this: @@ -427,7 +427,8 @@ retry: bgw.bgw_notify_pid = MyProcPid; bgw.bgw_main_arg = Int32GetDatum(slot); - if