Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES] toast index entries again)

2006-07-14 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Fri, 2006-07-14 at 14:20 -0400, Tom Lane wrote: >> I would like to propose that we revert all the include-related changes >> of the past two days, and that src/tools/pginclude be removed from the >> CVS tree, until such time as it is rewritten to be much

[HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES] toast index entries again)

2006-07-14 Thread Tom Lane
Kris Jurka <[EMAIL PROTECTED]> writes: > The inclusion of access/tuptoaster.h in access/common/indextuple.c brought > in the define of TOAST_INDEX_HACK which compresses large index entries. > When this was removed the entries were no longer compressed which caused > btree_gist to fail. This is