On 2 March 2017 at 03:19, Peter Eisentraut
wrote:
> On 2/26/17 21:28, Craig Ringer wrote:
>> Amended patch attached after a few Perl-related comments I got on
>> private mail. Instead of
>>
>> $exc_save !~ /^$timeout_exception.*/
>>
>> I've updated to:
>>
>> $exc_save !~ /^\Q$timeout_exception\E/
On 2/26/17 21:28, Craig Ringer wrote:
> Amended patch attached after a few Perl-related comments I got on
> private mail. Instead of
>
> $exc_save !~ /^$timeout_exception.*/
>
> I've updated to:
>
> $exc_save !~ /^\Q$timeout_exception\E/
>
> i.e. don't do an unnecessary wildcard match at the en
On 28 February 2017 at 20:39, Alvaro Herrera wrote:
> Lately I've been wondering about backpatching the whole TAP test
> infrastructure, all the way back. As we notice bugs, it's really useful
> to use newly added tests in all branches; but currently PostgresNode
> doesn't work with old branches
On 02/28/2017 07:39 AM, Alvaro Herrera wrote:
> Lately I've been wondering about backpatching the whole TAP test
> infrastructure, all the way back. As we notice bugs, it's really useful
> to use newly added tests in all branches; but currently PostgresNode
> doesn't work with old branches, part
Michael Paquier wrote:
> On Mon, Feb 27, 2017 at 11:28 AM, Craig Ringer wrote:
> > Instead of
> >
> > $exc_save !~ /^$timeout_exception.*/
> >
> > I've updated to:
> >
> > $exc_save !~ /^\Q$timeout_exception\E/
> >
> > i.e. don't do an unnecessary wildcard match at the end, and disable
> > metach
Michael Paquier writes:
> On Mon, Feb 27, 2017 at 11:28 AM, Craig Ringer wrote:
>
>> Still needs applying to pg9.6 and pg10.
>
> I did not understand at first what you meant, but after looking at the
> commit message of the patch things are clear:
> Newer Perl or IPC::Run versions default to app
On Mon, Feb 27, 2017 at 11:28 AM, Craig Ringer wrote:
> Amended patch attached after a few Perl-related comments I got on
> private mail.
Out of curiosity, what are they?
> Instead of
>
> $exc_save !~ /^$timeout_exception.*/
>
> I've updated to:
>
> $exc_save !~ /^\Q$timeout_exception\E/
>
> i.e
Amended patch attached after a few Perl-related comments I got on
private mail. Instead of
$exc_save !~ /^$timeout_exception.*/
I've updated to:
$exc_save !~ /^\Q$timeout_exception\E/
i.e. don't do an unnecessary wildcard match at the end, and disable
metachar interpretation in the substituted
Hi all
While writing some tests I noticed that in newer IPC::Run or Perl
versions (haven't dug extensively to find out which), perl appends the
location to the extension, so 'ne' doesn't match the passed exception
string.
Pattern-match the exception string to handle this.
Bugfix, should be appli