Chad Wagner [EMAIL PROTECTED] writes:
Just a heads up, not sure if you guys are aware of it. But one of the
Makefile's (src/backend/tsearch/Makefile) added by this patch breaks the
build out of source tree feature of autoconf/automake. The problem is
pretty straightforward, and after adding
Le mardi 21 août 2007, Oleg Bartunov a écrit :
On Mon, 20 Aug 2007, Tom Lane wrote:
I've applied version 0.58 of the patch with a lot of further
editorializing. I feel fairly confident now in the code that interfaces
Great ! Just checked and most things after trivial changes are working !
Tom Lane wrote:
Applied, thanks. (Hm, I thought we had some buildfarm machines testing
VPATH builds these days? Guess not ...)
I have switched dungbeetle to use vpath. It's a one line config file
change, and it builds every hour (3 a day for stable banches, remainder
for HEAD) if
Merlin Moncure wrote:
On 8/21/07, Magnus Hagander [EMAIL PROTECTED] wrote:
OTOH, if we do it as a compat package, we need to set a firm end-date on
it, so we don't have to maintain it forever.
I would suggest making a pgfoundry project...that's what was done with
userlocks. I'm pretty
On Mon, Aug 20, 2007 at 10:50:49PM -0400, Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
You broke my shiny new MinGW and Cygwin buildfarm members too :-)
Yeah, I was just looking at that. I seem to recall that the
fu01.o(.idata$3+0xc): undefined reference to
On Mon, Aug 20, 2007 at 09:23:25PM -0400, Tom Lane wrote:
I've applied version 0.58 of the patch with a lot of further
editorializing. I feel fairly confident now in the code that interfaces
between tsearch and the rest of the system, but a lot of the
lowest-level guts of tsearch (mainly in
Magnus Hagander wrote:
On Mon, Aug 20, 2007 at 09:23:25PM -0400, Tom Lane wrote:
I get awarning from the following line in bison generated parse.h:
#define TEXT 577
That's easy, change the terminal to TEXT_P on gram.y and keywords.c.
--
Alvaro Herrera
On Tue, Aug 21, 2007 at 10:59:52AM -0400, Tom Lane wrote:
Alvaro Herrera [EMAIL PROTECTED] writes:
Magnus Hagander wrote:
I get awarning from the following line in bison generated parse.h:
#define TEXT 577
That's easy, change the terminal to TEXT_P on gram.y and keywords.c.
Yeah, I
Alvaro Herrera [EMAIL PROTECTED] writes:
Magnus Hagander wrote:
I get awarning from the following line in bison generated parse.h:
#define TEXT 577
That's easy, change the terminal to TEXT_P on gram.y and keywords.c.
Yeah, I was wondering if we'd have to do that with any of the new
On Mon, 20 Aug 2007, Tom Lane wrote:
I've applied version 0.58 of the patch with a lot of further
editorializing. I feel fairly confident now in the code that interfaces
Great ! Just checked and most things after trivial changes are working !
We need to summarize changes and provide upgraide
Hi,
On Tue, 2007-08-21 at 20:04 +0400, Oleg Bartunov wrote:
It was really hard task for all of us. It's pity I don't drink at all,
but Teodor will drink the health of text search in PostgreSQL
today .
Haha :) I'd drink Vodka today, with some of my friends. (I'll drink
Absolut, and I know you
Tom Lane wrote:
I've applied version 0.58 of the patch with a lot of further
editorializing. I feel fairly confident now in the code that interfaces
between tsearch and the rest of the system, but a lot of the
lowest-level guts of tsearch (mainly in src/backend/tsearch/*.c and
Heikki Linnakangas [EMAIL PROTECTED] writes:
I'm skimming through tsearch code, trying to understand it. I'd like to
see more comments, at least function-comments explaining what each
function does, what the arguments are etc. I can try to add them as I go
as well, and send a patch.
Yes, the
Tom Lane wrote:
The memory management of the init functions looks weird. In spell.c,
there's this piece of code:
I saw that and didn't care for it much, but didn't look into exactly
what would be needed to get rid of it. (I did clean up another place
that had a *global* magic context
[EMAIL PROTECTED] (Tom Lane) writes:
The main thing that is lacking at the moment is documentation. The
stuff Bruce has been working on will be good introductory material,
but we've got basically zip in reference material. I'll do some work
on that over the next couple of days, but there's
Oleg Bartunov wrote:
On Mon, 20 Aug 2007, Tom Lane wrote:
I've applied version 0.58 of the patch with a lot of further
editorializing. I feel fairly confident now in the code that interfaces
Great ! Just checked and most things after trivial changes are working !
We need to summarize
Just a heads up, not sure if you guys are aware of it. But one of the
Makefile's (src/backend/tsearch/Makefile) added by this patch breaks the
build out of source tree feature of autoconf/automake. The problem is
pretty straightforward, and after adding $(srcdir) everything seems to be
fine.
On 8/21/07, Magnus Hagander [EMAIL PROTECTED] wrote:
OTOH, if we do it as a compat package, we need to set a firm end-date on
it, so we don't have to maintain it forever. Given the issues always at
hand for doing such an upgrade, my vote is actually for ripping it out
completely and take the
On Tue, 21 Aug 2007, Chris Browne wrote:
[EMAIL PROTECTED] (Tom Lane) writes:
The main thing that is lacking at the moment is documentation. The
stuff Bruce has been working on will be good introductory material,
but we've got basically zip in reference material. I'll do some work
on that
I've applied version 0.58 of the patch with a lot of further
editorializing. I feel fairly confident now in the code that interfaces
between tsearch and the rest of the system, but a lot of the
lowest-level guts of tsearch (mainly in src/backend/tsearch/*.c and
src/backend/utils/adt/ts*.c) left
Tom Lane wrote:
I am quite confident that this commit broke the MSVC build, which seems
to need to know individually about each shared library ... Magnus,
can you do something about that? We'll see what other portability
problems emerge from the buildfarm.
You broke my shiny new MinGW
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Tom Lane wrote:
Also, we need to decide what to do with contrib/tsearch2, which is
currently DOA because of conflicts with the new core code. We could
either rip it out entirely, or try to convert it into a compatibility
package. In view of the
Andrew Dunstan [EMAIL PROTECTED] writes:
You broke my shiny new MinGW and Cygwin buildfarm members too :-)
Yeah, I was just looking at that. I seem to recall that the
fu01.o(.idata$3+0xc): undefined reference to `libpostgres_a_iname'
bleat is a symptom of a reference to a variable
Tom Lane wrote:
The main thing that is lacking at the moment is documentation. The
stuff Bruce has been working on will be good introductory material,
but we've got basically zip in reference material. I'll do some work
on that over the next couple of days, but there's probably room for
Bruce Momjian [EMAIL PROTECTED] writes:
Oleg and Teodor did provide reference documentation. You can see the
SGML here:
http://momjian.us/expire/textsearch/SGML/ref/
The SQL commands were in a state of flux so I haven't worked on them
yet. I can start now.
OK. I whacked around the
25 matches
Mail list logo
