Re: [HACKERS] warning in twophase.c

2017-04-25 Thread Amit Langote
On 2017/04/25 16:16, Jeevan Ladhe wrote: > I have also been seeing this warning lately, I had tried to check git log, > and > seems like following commit 546c13e11b29 by Simon has introduced it. > > But per the commit log, this seems to be a temporary arrangement: > > commit

Re: [HACKERS] warning in twophase.c

2017-04-25 Thread Jeevan Ladhe
I have also been seeing this warning lately, I had tried to check git log, and seems like following commit 546c13e11b29 by Simon has introduced it. But per the commit log, this seems to be a temporary arrangement: commit 546c13e11b29a5408b9d6a6e3cca301380b47f7f Author: Simon Riggs

[HACKERS] warning in twophase.c

2017-04-24 Thread Amit Langote
Been seeing this warning recently: twophase.c: In function ‘RecoverPreparedTransactions’: twophase.c:1916:9: warning: variable ‘overwriteOK’ set but not used [-Wunused-but-set-variable] bool overwriteOK = false; ^~~ As the message says, the value of overwriteOK is not used