Re: [HACKERS] [COMMITTERS] pgsql: Add missing format attributes
On Sun, Sep 11, 2011 at 5:17 AM, Peter Eisentraut pete...@gmx.net wrote: Add missing format attributes Add __attribute__ decorations for printf format checking to the places that were missing them. Fix the resulting warnings. Add -Wmissing-format-attribute to the standard set of warnings for GCC, so these don't happen again. The warning fixes here are relatively harmless. The one serious problem discovered by this was already committed earlier in cf15fb5cabfbc71e07be23cfbc813daee6c5014f. This commit causes the following warning at the compile time. error.c: In function 'ecpg_raise_backend': error.c:339: warning: field precision should have type 'int', but argument 2 has type 'long unsigned int' Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [COMMITTERS] pgsql: Add missing format attributes
On sön, 2011-09-11 at 16:11 +0900, Fujii Masao wrote: On Sun, Sep 11, 2011 at 5:17 AM, Peter Eisentraut pete...@gmx.net wrote: Add missing format attributes Add __attribute__ decorations for printf format checking to the places that were missing them. Fix the resulting warnings. Add -Wmissing-format-attribute to the standard set of warnings for GCC, so these don't happen again. The warning fixes here are relatively harmless. The one serious problem discovered by this was already committed earlier in cf15fb5cabfbc71e07be23cfbc813daee6c5014f. This commit causes the following warning at the compile time. error.c: In function 'ecpg_raise_backend': error.c:339: warning: field precision should have type 'int', but argument 2 has type 'long unsigned int' Fixed, thanks. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
