Re: [HACKERS] [COMMITTERS] pgsql: Add new variable "server_version_num", which is almost the same

2006-09-02 Thread Tom Lane
I'd be less unhappy with this patch if the variable were not marked
GUC_REPORT.  That is what gives it nontrivial cost: it's adding a couple
dozen bytes to every connection startup exchange, for data that's 100%
redundant with data already being transmitted.

The arguments that were made in favor of this patch cited its possible
use in SQL scripts, but there is no need for the variable to be marked
GUC_REPORT for that usage.

regards, tom lane

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings


Re: [HACKERS] [COMMITTERS] pgsql: Add new variable "server_version_num", which is almost the same

2006-09-02 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes:
> Add new variable "server_version_num", which is almost the same as
> "server_version" but uses the handy PG_VERSION_NUM which allows apps to
> do things like if ($version >= 80200) without having to parse apart the
> value of server_version themselves.

I thought this was rejected as being utterly useless.  Or is this commit
somehow going to retroactively affect existing old servers?

A non-useless version of this would be client-side code ... except it's
already there, in libpq at least.

Please revert.

regards, tom lane

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster