Re: [HACKERS] [COMMITTERS] pgsql: Add pg_sequence system catalog

2017-01-24 Thread Peter Eisentraut
On 1/24/17 10:23 AM, Stephen Frost wrote: > It wouldn't hurt to add a comment as to why things are so different in > PG10 than other versions, ie: > > /* > * In PG10, sequence meta-data was moved into pg_sequence, so switch to > * the pg_catalog schema instead of operating in a user schema and p

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_sequence system catalog

2017-01-24 Thread Stephen Frost
Peter, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 1/19/17 11:03 AM, Stephen Frost wrote: > > I'd suggest using our usual approach in pg_dump, which is matching based > > on the OID, like so: > > > > WHERE c.oid = '%u'::oid > > > > The OID is in: tbinfo->dobj.catId.oid > >

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_sequence system catalog

2017-01-24 Thread Peter Eisentraut
On 1/19/17 11:03 AM, Stephen Frost wrote: > I'd suggest using our usual approach in pg_dump, which is matching based > on the OID, like so: > > WHERE c.oid = '%u'::oid > > The OID is in: tbinfo->dobj.catId.oid > > Also, you should move the selectSourceSchema() into the per-version > branches and

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_sequence system catalog

2017-01-23 Thread Stephen Frost
Peter, all, * Stephen Frost (sfr...@snowman.net) wrote: > * Peter Eisentraut (pete...@gmx.net) wrote: > > Add pg_sequence system catalog > > The query this added to dumpSequence() seems to think that sequence > names are unique across databases: Just FYI, I've added this to the PG10 open items l

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_sequence system catalog

2017-01-19 Thread Stephen Frost
Peter, * Peter Eisentraut (pete...@gmx.net) wrote: > Add pg_sequence system catalog The query this added to dumpSequence() seems to think that sequence names are unique across databases: appendPQExpBuffer(query, "SELECT seqstart, seqincrement, " "CASE WHEN seq