Re: [HACKERS] [COMMITTERS] pgsql: Ah, I finally realize why Magnus wanted to add a --bindir option

2006-07-21 Thread Peter Eisentraut
Tom Lane wrote:
 Ah, I finally realize why Magnus wanted to add a --bindir option to
 pg_regress: there's no other way to cope with testing a relocated
 installation.  Seems better to call it --psqldir though, since the
 only thing we need to find in that case is psql.

Well, if the ecpg tests materialize, maybe not.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match


Re: [HACKERS] [COMMITTERS] pgsql: Ah, I finally realize why Magnus

2006-07-21 Thread Andrew Dunstan

Peter Eisentraut wrote:

Tom Lane wrote:
  

Ah, I finally realize why Magnus wanted to add a --bindir option to
pg_regress: there's no other way to cope with testing a relocated
installation.  Seems better to call it --psqldir though, since the
only thing we need to find in that case is psql.



Well, if the ecpg tests materialize, maybe not.

  
Maybe installbindir or some such. As Tom has no doubt observed, this 
change also manages to handle the problem we faced in running 
installcheck under Msys, even when the installation is not relocated 
(buildfarm does not relocate the install - it installs in the configured 
path).


cheers

andrew

---(end of broadcast)---
TIP 4: Have you searched our list archives?

  http://archives.postgresql.org


Re: [HACKERS] [COMMITTERS] pgsql: Ah, I finally realize why Magnus

2006-07-21 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes:
 Peter Eisentraut wrote:
 Tom Lane wrote:
 Ah, I finally realize why Magnus wanted to add a --bindir option to
 pg_regress: there's no other way to cope with testing a relocated
 installation.  Seems better to call it --psqldir though, since the
 only thing we need to find in that case is psql.
 
 Well, if the ecpg tests materialize, maybe not.
 
 Maybe installbindir or some such.

The problem with --bindir is that it confuses the purpose with the
build/install-time bindir, which is actually nearly unrelated --- it'll
likely have a similar path tail, but path head could be completely
different.  (Confusing this purpose with bindir was why I failed to grok
the point to start with.)  Call it what you like so long as it ain't
bindir ...

regards, tom lane

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings