Re: [HACKERS] [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

2016-01-10 Thread Michael Paquier
On Sun, Jan 10, 2016 at 8:10 AM, Michael Paquier wrote: > On Sun, Jan 10, 2016 at 2:00 AM, Andrew Dunstan wrote: >> I downloaded the official Cygwin packages into a Cygwin instance and checked >> how they do things. As I rather expected, they do

Re: [HACKERS] [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

2016-01-09 Thread Andrew Dunstan
On 01/08/2016 11:17 AM, Tom Lane wrote: Alvaro Herrera writes: Alvaro Herrera wrote: Obviously this wasn't the best idea ever. Andrew suggests on IM to revert this on Cygwin to just do the "isatty" check as originally. Here's a proposed patch. Thoughts? Ugly,

Re: [HACKERS] [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

2016-01-09 Thread Michael Paquier
On Sun, Jan 10, 2016 at 2:00 AM, Andrew Dunstan wrote: > I downloaded the official Cygwin packages into a Cygwin instance and checked > how they do things. As I rather expected, they do not use pg_ctl at all to > install or run as a service. Rather, they use the standard

Re: [HACKERS] [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

2016-01-08 Thread Alvaro Herrera
Alvaro Herrera wrote: > Tom Lane wrote: > > Alvaro Herrera writes: > > > Blind attempt at a Cygwin fix > > > > According to > > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=brolga=2016-01-08%2014%3A51%3A27 > > > > brolga now tries to compile win32security.c,

Re: [HACKERS] [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

2016-01-08 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Blind attempt at a Cygwin fix > > According to > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=brolga=2016-01-08%2014%3A51%3A27 > > brolga now tries to compile win32security.c, which it evidently was not > doing

Re: [HACKERS] [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

2016-01-08 Thread Tom Lane
Alvaro Herrera writes: > Alvaro Herrera wrote: >> Obviously this wasn't the best idea ever. Andrew suggests on IM to >> revert this on Cygwin to just do the "isatty" check as originally. > Here's a proposed patch. Thoughts? Ugly, but it will hold the fort until