Re: [HACKERS] [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE

2006-07-03 Thread paolo romano
I'm keeping on studying multixact.c and log management, and I hope you can help me, as usual, in clearing my doubts.My doubts now concern MultixactID wrap-around management. Afaics, it is possible to spawn multixactids so quickly to have a wrap-around and to start overwriting the data stored in

Re: [HACKERS] [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE

2006-07-02 Thread Bruce Momjian
Neil Conway wrote: Log Message: --- Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep the read lock we hold on the table's parent relation until commit. Update equalfuncs.c for the new field in AlterTableCmd. Various improvements to comments, variable names, and

Re: [HACKERS] [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE

2006-07-02 Thread Alvaro Herrera
Bruce Momjian wrote: Neil Conway wrote: Log Message: --- Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep the read lock we hold on the table's parent relation until commit. Update equalfuncs.c for the new field in AlterTableCmd. Various improvements to