Re: [HACKERS] [COMMITTERS] pgsql: Remove -Wl,-undefined,dynamic_lookup in macOS build.

2016-10-09 Thread Robert Haas
On Fri, Oct 7, 2016 at 7:58 PM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Oct 7, 2016 at 7:14 PM, Tom Lane wrote: >>> BTW, OS X hasn't got libintl AFAICT: >>> What are you using to get past that? > >> MacPorts. > > OK, I'll take a look. Thanks. Everything seems OK again now. -- Robert

Re: [HACKERS] [COMMITTERS] pgsql: Remove -Wl,-undefined,dynamic_lookup in macOS build.

2016-10-07 Thread Tom Lane
Robert Haas writes: > On Fri, Oct 7, 2016 at 7:14 PM, Tom Lane wrote: >> BTW, OS X hasn't got libintl AFAICT: >> What are you using to get past that? > MacPorts. OK, I'll take a look. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.

Re: [HACKERS] [COMMITTERS] pgsql: Remove -Wl,-undefined,dynamic_lookup in macOS build.

2016-10-07 Thread Robert Haas
On Fri, Oct 7, 2016 at 7:14 PM, Tom Lane wrote: > I wrote: >> Robert Haas writes: >>> This broke the build for me. OS X Yosemite, 10.10.5. > >> Hm, probably means we need an explicit reference to -lintl when >> linking libpqwalreceiver.so. > > BTW, OS X hasn't got libintl AFAICT: > > # ./configu

Re: [HACKERS] [COMMITTERS] pgsql: Remove -Wl,-undefined,dynamic_lookup in macOS build.

2016-10-07 Thread Tom Lane
I wrote: > Robert Haas writes: >> This broke the build for me. OS X Yosemite, 10.10.5. > Hm, probably means we need an explicit reference to -lintl when > linking libpqwalreceiver.so. BTW, OS X hasn't got libintl AFAICT: # ./configure --enable-nls ... checking for library containing bind_textd

Re: [HACKERS] [COMMITTERS] pgsql: Remove -Wl,-undefined,dynamic_lookup in macOS build.

2016-10-07 Thread Tom Lane
Robert Haas writes: > On Wed, Oct 5, 2016 at 11:04 PM, Tom Lane wrote: >> Remove -Wl,-undefined,dynamic_lookup in macOS build. > This broke the build for me. OS X Yosemite, 10.10.5. Hm, probably means we need an explicit reference to -lintl when linking libpqwalreceiver.so.

Re: [HACKERS] [COMMITTERS] pgsql: Remove -Wl,-undefined,dynamic_lookup in macOS build.

2016-10-07 Thread Robert Haas
On Wed, Oct 5, 2016 at 11:04 PM, Tom Lane wrote: > Remove -Wl,-undefined,dynamic_lookup in macOS build. > > We don't need this anymore, and it prevents build-time error checking > that's usually good to have, so remove it. Undoes one change of commit > cac765820. > > Unfortunately, it's much hard