Re: [HACKERS] [GENERAL] WIN32 Build?
[ redirecting to -hackers, as this seems utterly off-topic for -general ] Bruce Momjian [EMAIL PROTECTED] writes: Shoaib Mir wrote: If you remove inline the build process goes fine and if you dont, it first gives a few warning and in the end quits the build process with a fatal error. OK, good to know. If we ever find a symbol that is defined for that compiler that we can test, we can fix this. If we were running the actual configure script, presumably it would figure out that inline doesn't work on this compiler. I suppose the problem here is that there's 0 chance of that in a pure-Microsoft build environment. Should we just dumb pg_config.h.win32 down to the lowest common denominator, and make it #define inline as empty for any Windows build environment that can't run configure? I don't think we care that much about inline-ing on the client side anyway. regards, tom lane ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [HACKERS] [GENERAL] WIN32 Build?
Shoaib Mir [EMAIL PROTECTED] writes: As a workaround if you dont want to make the change and delete inline from wchar.c then you can do the following change in the win32.mak file for libpq: WIN32 /D _WINDOWS /D inline=__inline /Fp$(INTDIR)\libpq.pch /YX\ That's even stranger: it will accept __inline but not inline? But anyway, if that works I suggest we make pg_config.h.win32 #define inline as __inline and see if that works on all Windows compilers. regards, tom lane ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] [GENERAL] WIN32 Build?
Hi. Probably, the problem is happened in 8.1.4 of an official archive. http://archives.postgresql.org/pgsql-patches/2006-05/msg00232.php It is already clear at include/port/win32.h. And it is used as pg_config_os.h. Regards, Hiroshi Saito - Original Message - From: Tom Lane [EMAIL PROTECTED] Shoaib Mir [EMAIL PROTECTED] writes: As a workaround if you dont want to make the change and delete inline from wchar.c then you can do the following change in the win32.mak file for libpq: WIN32 /D _WINDOWS /D inline=__inline /Fp$(INTDIR)\libpq.pch /YX\ That's even stranger: it will accept __inline but not inline? But anyway, if that works I suggest we make pg_config.h.win32 #define inline as __inline and see if that works on all Windows compilers. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [HACKERS] [GENERAL] WIN32 Build?
Hiroshi Saito wrote: Hi. Probably, the problem is happened in 8.1.4 of an official archive. http://archives.postgresql.org/pgsql-patches/2006-05/msg00232.php It is already clear at include/port/win32.h. And it is used as pg_config_os.h. Actually, the patch you referenced was placed in port/win32.h in CVS HEAD, but not in 8.1.X becuase I thought it was only for MSVC compiles of the backend. 8.1.X fixed, and comment added. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 6: explain analyze is your friend
