Re: [HACKERS] [NOVICE] Why is there a doubtful copyObject call in add_vars_to_targetlist

2017-03-12 Thread Neha Khatri
Sure, understood. Regards, Neha

Re: [HACKERS] [NOVICE] Why is there a doubtful copyObject call in add_vars_to_targetlist

2017-03-12 Thread Tom Lane
Neha Khatri writes: > Then, should it be alright to remove the doubt itself? It's a perfectly legitimate comment describing a potential optimization. There are lots of other similar comments that might or might not ever get addressed. regards, tom

Re: [HACKERS] [NOVICE] Why is there a doubtful copyObject call in add_vars_to_targetlist

2017-03-12 Thread Neha Khatri
On Mon, Mar 13, 2017 at 3:52 PM, Tom Lane wrote: > David Rowley writes: > > On 13 March 2017 at 14:22, Neha Khatri wrote: > >> This copyObject still exits in the current code. So I was wondering if > the > >> comment

Re: [HACKERS] [NOVICE] Why is there a doubtful copyObject call in add_vars_to_targetlist

2017-03-12 Thread Tom Lane
David Rowley writes: > On 13 March 2017 at 14:22, Neha Khatri wrote: >> This copyObject still exits in the current code. So I was wondering if the >> comment question still holds good and why the question there in first place. >> To make a new

Re: [HACKERS] [NOVICE] Why is there a doubtful copyObject call in add_vars_to_targetlist

2017-03-12 Thread David Rowley
(Redirecting to Hackers, since Novice is not the correct place for this question) On 13 March 2017 at 14:22, Neha Khatri wrote: > Hi, > > I was debugging that when does the function _copyVar get invoked, and the > first hit for that was in the add_vars_to_targetlist.