Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-12-01 Thread Haribabu Kommi
On Thu, Nov 17, 2016 at 12:57 PM, Haribabu Kommi wrote: > Hi Dmitry, > > This is a gentle reminder. > > you assigned as reviewer to the current patch in the 11-2016 commitfest. > But you haven't shared your review yet. Can you please try to share your > views > about the patch. This will help us

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-11-16 Thread Haribabu Kommi
Hi Dmitry, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Can you please try to share your views about the patch. This will help us in smoother operation of commitfest. some people are against to the cur

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-10-18 Thread Aleksander Alekseev
> > According to my colleagues it would be very nice to have this feature. > > For instance, if you are trying to optimize PostgreSQL for application > > that uses COPY and you don't have access to or something like this. > > It could also be useful in some other cases. > > This use-case doesn't

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-10-17 Thread Daniel Verite
Aleksander Alekseev wrote: > According to my colleagues it would be very nice to have this feature. > For instance, if you are trying to optimize PostgreSQL for application > that uses COPY and you don't have access to or something like this. > It could also be useful in some other cases.

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-10-17 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Andrew Dunstan writes: > > On 10/17/2016 09:57 AM, Aleksander Alekseev wrote: > >> Sometimes it's useful to log content of files used in COPY ... TO ... and > >> COPY ... FROM ... queries. Unfortunately PostgreSQL doesn't allow to do > >> it, even if log_st

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-10-17 Thread Aleksander Alekseev
> > I'm not in favor of this, especially if it's not even optional. > > I'm not either. It sounds good when you're looking at toy examples, > but not when it means repeating gigabytes of COPY data into the log. I understand your concern. Perhaps we could create and additional parameter for enab

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-10-17 Thread Tom Lane
Andrew Dunstan writes: > On 10/17/2016 09:57 AM, Aleksander Alekseev wrote: >> Sometimes it's useful to log content of files used in COPY ... TO ... and >> COPY ... FROM ... queries. Unfortunately PostgreSQL doesn't allow to do >> it, even if log_statement='all'. Suggested patch fixes this. > I'm

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-10-17 Thread Andrew Dunstan
On 10/17/2016 09:57 AM, Aleksander Alekseev wrote: Hello. Sometimes it's useful to log content of files used in COPY ... TO ... and COPY ... FROM ... queries. Unfortunately PostgreSQL doesn't allow to do it, even if log_statement='all'. Suggested patch fixes this. Log example: ``` LOG: stat