Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-09-01 Thread Simone Gotti
On Fri, Sep 1, 2017 at 4:31 PM, Alvaro Herrera wrote: > > Both patches pushed, which should close the open item. Hi Alvaro, thanks a lot! Cheers, Simone. > > -- > Álvaro Herrerahttps://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support,

Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-09-01 Thread Alvaro Herrera
Both patches pushed, which should close the open item. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-08-30 Thread Alvaro Herrera
And another patch to restore behavior to replication origin drop. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From 66c1b1072feb95a08739d9a752f1d6fc73d1dc77 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera

Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-08-30 Thread Alvaro Herrera
Craig Ringer wrote: > > FWIW, I also don't think it's ok to just change the behaviour > > unconditionally and without a replacement for existing behaviour. > > Seems like it just needs a new argument nowait DEFAULT false I added a WAIT flag to DROP_REPLICATION_SLOT, preliminary patch attached.

Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-08-29 Thread Craig Ringer
On 29 August 2017 at 22:02, Andres Freund wrote: > Hi, > > On 2017-08-29 13:42:05 +0200, Simone Gotti wrote: > > On Tue, Aug 29, 2017 at 12:13 PM, Alvaro Herrera > > wrote: > > > > > > > Hi Alvaro, > > > > > Simone Gotti wrote: > > > > Hi all, > > >

Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-08-29 Thread Andres Freund
Hi, On 2017-08-29 13:42:05 +0200, Simone Gotti wrote: > On Tue, Aug 29, 2017 at 12:13 PM, Alvaro Herrera > wrote: > > > > Hi Alvaro, > > > Simone Gotti wrote: > > > Hi all, > > > > > > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an > > >

Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-08-29 Thread Simone Gotti
On Tue, Aug 29, 2017 at 12:13 PM, Alvaro Herrera wrote: > Hi Alvaro, > Simone Gotti wrote: > > Hi all, > > > > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an > > active slot will block until it's released instead of returning an error > >

Re: [HACKERS] [PATCH] Fix drop replication slot blocking instead of returning error

2017-08-29 Thread Alvaro Herrera
Simone Gotti wrote: > Hi all, > > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an > active slot will block until it's released instead of returning an error > like > done in pg 9.6. Since this is a change in the previous behavior and the docs > wasn't changed I made a