Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-10-05 Thread Marti Raudsepp
On Wed, Oct 5, 2011 at 02:36, gabrielle gor...@gmail.com wrote: This review was compiled from a PDXPUG group review (Dan Colish, Mark Wong, Brent Dombrowski, and Gabrielle Roth). Whaat, you marked the patch as Returned with Feedback based on this review? The only obvious change I need to make

Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-10-04 Thread gabrielle
This review was compiled from a PDXPUG group review (Dan Colish, Mark Wong, Brent Dombrowski, and Gabrielle Roth). -- We all agree this is a really useful feature. The patch applies cleanly to the current git master with git apply, it's in context diff, and does what it's supposed to do on

Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-10-04 Thread Marti Raudsepp
On Wed, Oct 5, 2011 at 02:36, gabrielle gor...@gmail.com wrote: This review was compiled from a PDXPUG group review (Dan Colish, Mark Wong, Brent Dombrowski, and Gabrielle Roth). Hi, thanks for the review! - Regression test requires plpythonu;  it needs to work without that. The patch

Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-09-27 Thread Florian Pflug
On Sep28, 2011, at 00:19 , Marti Raudsepp wrote: (I'm still not sure what adt means) I always assumed it stood for abstract data type. Most of the files in this directory seem to correspond to an SQL-level data type like intX, varchar, tsquery, ..., and contain the I/O functions for that type,

Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-09-27 Thread Tom Lane
Florian Pflug f...@phlo.org writes: On Sep28, 2011, at 00:19 , Marti Raudsepp wrote: (I'm still not sure what adt means) I always assumed it stood for abstract data type. Yeah, that's what I think too. Over time it's been used to hold most code that is a SQL-callable function, many of which