Re: [HACKERS] [PATCH] Log crashed backend's query v3

2011-10-21 Thread Marti Raudsepp
Hi, here's version 4 of the patch. On Wed, Oct 19, 2011 at 19:34, Robert Haas robertmh...@gmail.com wrote: I think it would be safer to write this so that pgstat_get_crashed_backend_activity writes its answer into a statically allocated buffer and returns a pointer to that buffer, rather than

Re: [HACKERS] [PATCH] Log crashed backend's query v3

2011-10-21 Thread Robert Haas
On Fri, Oct 21, 2011 at 11:45 AM, Marti Raudsepp ma...@juffo.org wrote: It's almost making me cry thinking about how much time this would have saved me Thanks for your review and the generous words. :) I have committed this version. I'm expecting Tom to try to find a scenario in which it's

Re: [HACKERS] [PATCH] Log crashed backend's query v3

2011-10-21 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I have committed this version. I'm expecting Tom to try to find a scenario in which it's unfixably broken, so we'll see how that turns out; but there seems to be significant support for this feature and I'm hopeful that this will pass (or can be made

Re: [HACKERS] [PATCH] Log crashed backend's query v3

2011-10-21 Thread Robert Haas
On Fri, Oct 21, 2011 at 4:37 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I have committed this version.  I'm expecting Tom to try to find a scenario in which it's unfixably broken, so we'll see how that turns out; but there seems to be significant support

Re: [HACKERS] [PATCH] Log crashed backend's query v3

2011-10-19 Thread Robert Haas
On Thu, Oct 6, 2011 at 10:15 PM, gabrielle gor...@gmail.com wrote: On Wed, Oct 5, 2011 at 5:14 PM, Marti Raudsepp ma...@juffo.org wrote: I think you intended to use the Waiting on Author status -- that leaves the commitfest entry open. I will re-open the commitfest entry myself, I hope that's

Re: [HACKERS] [PATCH] Log crashed backend's query v3

2011-10-06 Thread gabrielle
On Wed, Oct 5, 2011 at 5:14 PM, Marti Raudsepp ma...@juffo.org wrote: I think you intended to use the Waiting on Author status -- that leaves the commitfest entry open. I will re-open the commitfest entry myself, I hope that's OK. No worries, and yeah, I picked the wrong checkbox. :) Here is