Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-04-04 Thread Michael Paquier
On Wed, Apr 5, 2017 at 12:39 AM, Stephen Frost wrote: > Committed, with those additions. Thanks for the commit. The final result is nice. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-04-04 Thread Stephen Frost
Greetings, * Craig Ringer (cr...@2ndquadrant.com) wrote: > On 31 March 2017 at 04:29, Stephen Frost wrote: > > > Unless people wish to object, I'll use Michael's patch to remove > > --verbose from the top level tomorrow. > > Sounds good. > > Maybe add > > To get more

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-30 Thread Craig Ringer
On 31 March 2017 at 04:29, Stephen Frost wrote: > Unless people wish to object, I'll use Michael's patch to remove > --verbose from the top level tomorrow. Sounds good. Maybe add To get more detailed output from tests set PROVE_FLAGS='--verbose' or examine the detailed

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-30 Thread Stephen Frost
Tom, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I'd be fine with removing --verbose globally, as your patch does, but > > there was some argument that we then would have long 'quiet' periods. > > I haven't had a chance to go test if that's really

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-30 Thread Tom Lane
Stephen Frost writes: > I'd be fine with removing --verbose globally, as your patch does, but > there was some argument that we then would have long 'quiet' periods. > I haven't had a chance to go test if that's really the case yet though. I've been running it like this

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-30 Thread Craig Ringer
On 30 March 2017 at 20:57, Michael Paquier wrote: > I don't see much the point to have --verbose enabled by default, but > if that's the consensus I have nothing better to propose than adding > something like that to the command launching the prove command: $(if >

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-30 Thread Alvaro Herrera
Stephen Frost wrote: > I'd be fine with removing --verbose globally, as your patch does, but > there was some argument that we then would have long 'quiet' periods. > I haven't had a chance to go test if that's really the case yet though. Michael said that a running counter was displayed, which

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-30 Thread Michael Paquier
On Thu, Mar 30, 2017 at 9:52 PM, Stephen Frost wrote: > Michael, > > * Michael Paquier (michael.paqu...@gmail.com) wrote: >> On Thu, Mar 30, 2017 at 4:08 AM, Stephen Frost wrote: >> >> > If there's a way to change the verbosity for just those scripts, I'd

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-30 Thread Stephen Frost
Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Thu, Mar 30, 2017 at 4:08 AM, Stephen Frost wrote: > >> > If there's a way to change the verbosity for just those scripts, I'd be > >> > happy to do that, if we're unable to agree on reducing it across the >

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-29 Thread Michael Paquier
On Thu, Mar 30, 2017 at 4:08 AM, Stephen Frost wrote: > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: >> Stephen Frost wrote: >> > * Dagfinn Ilmari Mannsåker (ilm...@ilmari.org) wrote: >> >> > > Non-verbose prove still lists each test script, it just doesn't list >> > >

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-29 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > * Dagfinn Ilmari Mannsåker (ilm...@ilmari.org) wrote: > > > > Non-verbose prove still lists each test script, it just doesn't list > > > each individual test within the script. > > > > I agree that it'd be better to

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-29 Thread Alvaro Herrera
Stephen Frost wrote: > * Dagfinn Ilmari Mannsåker (ilm...@ilmari.org) wrote: > > Non-verbose prove still lists each test script, it just doesn't list > > each individual test within the script. > > I agree that it'd be better to just show the per-script results rather > than every little test

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-29 Thread Stephen Frost
* Dagfinn Ilmari Mannsåker (ilm...@ilmari.org) wrote: > Peter Eisentraut writes: > > > On 3/28/17 23:42, Michael Paquier wrote: > >> src/bin/pg_dump and src/test/modules/test_pgdump generate too much > >> output. If we could get tests to only print the final

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-29 Thread Dagfinn Ilmari Mannsåker
Peter Eisentraut writes: > On 3/28/17 23:42, Michael Paquier wrote: >> src/bin/pg_dump and src/test/modules/test_pgdump generate too much >> output. If we could get tests to only print the final result, like how >> many tests done and how many have passed,

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-29 Thread Peter Eisentraut
On 3/28/17 23:42, Michael Paquier wrote: > src/bin/pg_dump and src/test/modules/test_pgdump generate too much > output. If we could get tests to only print the final result, like how > many tests done and how many have passed, things would be much > friendlier. There are options to change the

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-28 Thread Michael Paquier
On Wed, Mar 29, 2017 at 12:37 PM, Craig Ringer wrote: > On 29 March 2017 at 08:57, Peter Eisentraut > wrote: >> On 3/22/17 03:18, Craig Ringer wrote: >>> Trivial patch to change 'diag' to 'note' in TAP tests in >>> src/test/recovery

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-28 Thread Craig Ringer
On 29 March 2017 at 08:57, Peter Eisentraut wrote: > On 3/22/17 03:18, Craig Ringer wrote: >> Trivial patch to change 'diag' to 'note' in TAP tests in >> src/test/recovery attached. >> >> It'll reduce the test output a little. > > Committed, and also done the

Re: [HACKERS] [PATCH] Reduce src/test/recovery verbosity

2017-03-28 Thread Peter Eisentraut
On 3/22/17 03:18, Craig Ringer wrote: > Trivial patch to change 'diag' to 'note' in TAP tests in > src/test/recovery attached. > > It'll reduce the test output a little. Committed, and also done the same in src/test/ssl/. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL