Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-10-02 Thread chenhj
On 2017-10-02 23:24:30，"Alexander Korotkov" wrote: On Sun, Oct 1, 2017 at 8:27 PM, chenhj wrote: Now, this patch looks good for me. It applies cleanly, builds cleanly, passes regression tests, new functionality is covered by regression tests.

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-10-02 Thread Alexander Korotkov
On Sun, Oct 1, 2017 at 8:27 PM, chenhj wrote: > On 2017-10-01 04:09:19,"Alexander Korotkov" > wrote: > > On Sat, Sep 30, 2017 at 8:18 PM, chenhj wrote: > >> On 2017-09-30 02:17:54，"Alexander Korotkov" >

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-10-01 Thread chenhj
On 2017-10-01 04:09:19,"Alexander Korotkov" wrote: On Sat, Sep 30, 2017 at 8:18 PM, chenhj wrote: On 2017-09-30 02:17:54，"Alexander Korotkov" wrote: Great. Now code of this patch looks good for me. However, we forgot

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-30 Thread Alexander Korotkov
On Sat, Sep 30, 2017 at 8:18 PM, chenhj wrote: > On 2017-09-30 02:17:54，"Alexander Korotkov" > wrote: > > > Great. Now code of this patch looks good for me. > However, we forgot about documentation. > > >>The result is equivalent to replacing

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-30 Thread chenhj
On 2017-09-30 02:17:54，"Alexander Korotkov" wrote: Great. Now code of this patch looks good for me. However, we forgot about documentation. The result is equivalent to replacing the target data directory with the source one. Only changed blocks from

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-29 Thread Alexander Korotkov
On Fri, Sep 29, 2017 at 8:10 PM, chenhj wrote: > On 2017-09-30 00:53:31，"chenhj" wrote: > > On 2017-09-29 19:29:40，"Alexander Korotkov" > wrote: > > On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote: >> >> >> > OK.

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-29 Thread chenhj
On 2017-09-30 00:53:31，"chenhj" wrote: On 2017-09-29 19:29:40，"Alexander Korotkov" wrote: On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote: OK. That makes sense. Thank you for the explanation. I still have some minor

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-29 Thread chenhj
On 2017-09-29 19:29:40，"Alexander Korotkov" wrote: On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote: OK. That makes sense. Thank you for the explanation. I still have some minor comments. /* +* Save the WAL filenames of the divergence

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-29 Thread Alexander Korotkov
On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote: > On 2017-09-29 05:31:51, "Alexander Korotkov" > wrote: > > On Thu, Sep 28, 2017 at 10:52 PM, chenhj wrote: > >> On 2017-09-29 00:43:18，"Alexander Korotkov"

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-29 Thread chenhj
On 2017-09-29 05:31:51, "Alexander Korotkov" wrote: On Thu, Sep 28, 2017 at 10:52 PM, chenhj wrote: On 2017-09-29 00:43:18，"Alexander Korotkov" wrote: On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote: On

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-28 Thread Alexander Korotkov
On Thu, Sep 28, 2017 at 10:52 PM, chenhj wrote: > On 2017-09-29 00:43:18，"Alexander Korotkov" > wrote: > > On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote: > >> On 2017-09-28 01:29:29，"Alexander Korotkov"

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-28 Thread chenhj
On 2017-09-29 00:43:18，"Alexander Korotkov" wrote: On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote: On 2017-09-28 01:29:29，"Alexander Korotkov" wrote: It appears that your patch conflicts with fc49e24f. Please, rebase it.

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-28 Thread Alexander Korotkov
On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote: > On 2017-09-28 01:29:29，"Alexander Korotkov" > wrote: > > It appears that your patch conflicts with fc49e24f. Please, rebase it. > > > Yes, i had rebased it, Please check the new patch. > Good, now it

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-28 Thread chenhj
On 2017-09-28 01:29:29，"Alexander Korotkov" wrote: It appears that your patch conflicts with fc49e24f. Please, rebase it. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company Yes, i had rebased it, Please

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-27 Thread Alexander Korotkov
On Mon, Sep 25, 2017 at 6:26 PM, chenhj wrote: > On 2017-09-23 01:59:0, "Alexander Korotkov" > wrote: > > On Fri, Sep 22, 2017 at 7:16 PM, chenhj wrote: > >> This is the new pacth with TAP test and use Macro XLOGDIR. >> > > Good.

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-25 Thread chenhj
On 2017-09-23 01:59:0, "Alexander Korotkov" wrote: On Fri, Sep 22, 2017 at 7:16 PM, chenhj wrote: This is the new pacth with TAP test and use Macro XLOGDIR. Good. I took a quick look over the patch. Why do you need master_query(), standby_query()

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-22 Thread Alexander Korotkov
On Fri, Sep 22, 2017 at 7:16 PM, chenhj wrote: > This is the new pacth with TAP test and use Macro XLOGDIR. > Good. I took a quick look over the patch. Why do you need master_query(), standby_query() and run_query() in RewindTest.pm? You can do just $node_master->safe_psql()

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-22 Thread chenhj
Hi This is the new pacth with TAP test and use Macro XLOGDIR. And i had add this patch to the commitfest, https://commitfest.postgresql.org/15/1302/ -- Best Regards, Chen Huajun pg_rewind_wal_copy_reduce_v2.patch Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-18 Thread chenhj
At 2017-09-17 08:33:33, "Michael Paquier" wrote: >On Sun, Sep 17, 2017 at 3:19 AM, Alexander Korotkov > wrote: >> Hi! >> >> On Sat, Sep 16, 2017 at 5:56 PM, chenhj wrote: >>> >>> This patch optimizes the above mentioned

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-16 Thread Michael Paquier
On Sun, Sep 17, 2017 at 3:19 AM, Alexander Korotkov wrote: > Hi! > > On Sat, Sep 16, 2017 at 5:56 PM, chenhj wrote: >> >> This patch optimizes the above mentioned issues, as follows: >> 1. In the target data directory, do not delete the WAL files

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2017-09-16 Thread Alexander Korotkov
Hi! On Sat, Sep 16, 2017 at 5:56 PM, chenhj wrote: > This patch optimizes the above mentioned issues, as follows: > 1. In the target data directory, do not delete the WAL files before the > divergence. > 2. When copying files from the source server, do not copy the WAL files >