On 9/9/16 3:19 AM, Fabien COELHO wrote:
>
>> I have updated the patch with additional tests and comments per your
>> review. Final(?) version attached.
>
> Applied on head, make check ok. No more comments on the code which does
> what it says. I'm fine with this patch.
Pushed, thanks.
--
I have updated the patch with additional tests and comments per your
review. Final(?) version attached.
Applied on head, make check ok. No more comments on the code which does
what it says. I'm fine with this patch.
--
Fabien.
--
Sent via pgsql-hackers mailing list
I have updated the patch with additional tests and comments per your
review. Final(?) version attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From ee34d7d64a4b10c9f7fbe8c905a56cea1584c8c9 Mon Sep 17
Hello Peter,
My 0.02€ (not $0.02:-) comments on this patch:
Patch applies and "make check" is ok. I see no issue with the code.
A few comments below.
The regression tests are clearer & commented, it is an improvement.
While you are at it, maybe you could consider adding tests for more
