Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for

2006-09-14 Thread Bruce Momjian
OK, removed from open item list. --- Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I've applied this but I'm now having some second thoughts about it, > >> because I'm seeing an actual

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-09-11 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I've applied this but I'm now having some second thoughts about it, >> because I'm seeing an actual *decrease* in pgbench numbers from the >> immediately prior CVS HEAD code. > The attached patch requires the new row to fit, and 10% to

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for

2006-09-02 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom, should I apply this patch now? Are you still considering other > options for this? Please wait. This issue is very far down the to-list in terms of size or significance ... but I'll get to it. regards, tom lane --

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for

2006-09-02 Thread Bruce Momjian
Tom, should I apply this patch now? Are you still considering other options for this? --- Bruce Momjian wrote: > > Tom, I ran your tests with fsync off (as you did), and saw numbers > bouncing between 400-700 tps without m

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-08-09 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Have we made a decision on this issue? Should I apply my patch that > still forces a split unless 10% of the page has been freed? I haven't gotten back to doing any more performance testing. Please stick that patch on the pending queue, so we don't for

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-08-09 Thread Bruce Momjian
Have we made a decision on this issue? Should I apply my patch that still forces a split unless 10% of the page has been freed? --- Tom Lane wrote: > ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > > This is a revised patch

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-28 Thread Jim C. Nasby
On Thu, Jul 27, 2006 at 05:24:35PM -0400, Greg Stark wrote: > > Jim Nasby <[EMAIL PROTECTED]> writes: > > > Even if we stopped right there it would still be a huge win in many (most?) > > cases. How often do the indexes on a table comprise even 50% of the table's > > size? > > I would say the

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-27 Thread Greg Stark
Jim Nasby <[EMAIL PROTECTED]> writes: > Even if we stopped right there it would still be a huge win in many (most?) > cases. How often do the indexes on a table comprise even 50% of the table's > size? I would say they're usually roughly comparable actually. It depends on how wide your table

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-27 Thread Jim Nasby
On Jul 26, 2006, at 10:29 AM, Tom Lane wrote: Gregory Stark <[EMAIL PROTECTED]> writes: ... Well it's not like the existing vacuum checks for this. Right, that's exactly why the patch works at all. But the point here is that the existing vacuum does not rely on re-computing index keys; all

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-27 Thread Jim Nasby
On Jul 26, 2006, at 4:29 PM, Hannu Krosing wrote: Well the desire for it comes from a very well established need for dealing with extremely large tales with relatively small hot spots. The basic problem being that currently the cost of vacuum is proportional to the size of the table rather t

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-26 Thread Hannu Krosing
Ühel kenal päeval, K, 2006-07-26 kell 23:02, kirjutas Martijn van Oosterhout: > On Wed, Jul 26, 2006 at 12:47:57PM -0400, Greg Stark wrote: > > Tom Lane <[EMAIL PROTECTED]> writes: > > > > > So far, the case hasn't been made for retail vacuum even ignoring the > > > not-so-immutable-function risk.

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-26 Thread Martijn van Oosterhout
On Wed, Jul 26, 2006 at 12:47:57PM -0400, Greg Stark wrote: > Tom Lane <[EMAIL PROTECTED]> writes: > > > So far, the case hasn't been made for retail vacuum even ignoring the > > not-so-immutable-function risk. > > Well the desire for it comes from a very well established need for dealing > with

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-26 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > So far, the case hasn't been made for retail vacuum even ignoring the > not-so-immutable-function risk. Well the desire for it comes from a very well established need for dealing with extremely large tales with relatively small hot spots. The basic problem b

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-26 Thread Tom Lane
Csaba Nagy <[EMAIL PROTECTED]> writes: >> [snip] (In fact, it's >> trivial to see how user-defined functions that are mislabeled immutable >> could make this fail.) So retail vacuum without any cross-check that >> you got all the index tuples is a scary proposition IMHO. > Wouldn't work to restri

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-26 Thread Csaba Nagy
> [snip] (In fact, it's > trivial to see how user-defined functions that are mislabeled immutable > could make this fail.) So retail vacuum without any cross-check that > you got all the index tuples is a scary proposition IMHO. Wouldn't work to restrict that kind of vacuum to only tables which h

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-26 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > ... Well it's not like the existing vacuum checks for this. Right, that's exactly why the patch works at all. But the point here is that the existing vacuum does not rely on re-computing index keys; all it cares about is matching TIDs. The retail-vacuu

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-26 Thread Gregory Stark
Tom Lane <[EMAIL PROTECTED]> writes: > ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > > This is a revised patch originated by Junji TERAMOTO for HEAD. > > [BTree vacuum before page splitting] > > http://archives.postgresql.org/pgsql-patches/2006-01/msg00301.php > > I think we can resurrect hi

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-25 Thread Bruce Momjian
Tom, I ran your tests with fsync off (as you did), and saw numbers bouncing between 400-700 tps without my patch, and sticking at 700 tps with my patch. --- Bruce Momjian wrote: > > The attached patch requires the new row t

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-25 Thread Bruce Momjian
The attached patch requires the new row to fit, and 10% to be free on the page. Would someone test that? --- Tom Lane wrote: > ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > > This is a revised patch originated by Junji TER

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-25 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > This is a revised patch originated by Junji TERAMOTO for HEAD. > [BTree vacuum before page splitting] > http://archives.postgresql.org/pgsql-patches/2006-01/msg00301.php > I think we can resurrect his idea because we will scan btree pages > at-atim

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-25 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > I think we can resurrect his idea because we will scan btree pages > at-atime now; the missing-restarting-point problem went away. > Have I missed something? Comments welcome. I was thinking for awhile just now that this would break the interlock tha

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-24 Thread Bruce Momjian
Tom Lane wrote: > ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > > This is a revised patch originated by Junji TERAMOTO for HEAD. > > [BTree vacuum before page splitting] > > http://archives.postgresql.org/pgsql-patches/2006-01/msg00301.php > > I think we can resurrect his idea because we will

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-24 Thread Heikki Linnakangas
On Mon, 24 Jul 2006, Tom Lane wrote: Personally I don't think retail vacuuming in that form will ever fly anyway, so I have no problem with installing the proposed patch, but I thought I'd better throw this comment out to see if anyone thinks it's a big deal. My feeling is that retail vacuumin

Re: [HACKERS] [PATCHES] Resurrecting per-page cleaner for btree

2006-07-24 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > This is a revised patch originated by Junji TERAMOTO for HEAD. > [BTree vacuum before page splitting] > http://archives.postgresql.org/pgsql-patches/2006-01/msg00301.php > I think we can resurrect his idea because we will scan btree pages > at-atim