Re: [HACKERS] [PATCHES] pg_strcasecmp in fe-connect.c

2006-09-16 Thread Magnus Hagander
This patch fixes a couple of cases where we use strcasecmp() instead of pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc. Applied. I found another instance in contrib/hstore, too. Ah. msvc builds don't currently build /contrib, that's why I missed that one.

Re: [HACKERS] [PATCHES] pg_strcasecmp in fe-connect.c

2006-09-16 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: There are also some occurrences in pgbench.c, but I'm unsure that we need be paranoid about changing those. If we ever want to be able to compile it on a platform that doesn't have strcasecmp() (such as MSVC++), we would, no? OK, replaced 'em all.

Re: [HACKERS] [PATCHES] pg_strcasecmp in fe-connect.c

2006-09-15 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: This patch fixes a couple of cases where we use strcasecmp() instead of pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc. Applied. I found another instance in contrib/hstore, too. There are also some occurrences in pgbench.c, but I'm