Re: [HACKERS] [sqlsmith] crashes in RestoreSnapshot on hot standby

2016-07-01 Thread Robert Haas
On Fri, Jul 1, 2016 at 1:41 AM, Andreas Seltenreich wrote: > Amit Kapila writes: >> On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro >> wrote: >>> Or maybe just like this? >>> >>> - snapshot->subxip = snapshot->xip + >>>

Re: [HACKERS] [sqlsmith] crashes in RestoreSnapshot on hot standby

2016-06-30 Thread Andreas Seltenreich
Amit Kapila writes: > On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro > wrote: >> Or maybe just like this? >> >> - snapshot->subxip = snapshot->xip + serialized_snapshot->xcnt; >> + snapshot->subxip = ((TransactionId *) (snapshot + 1)) + >>

Re: [HACKERS] [sqlsmith] crashes in RestoreSnapshot on hot standby

2016-06-30 Thread Amit Kapila
On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro wrote: > On Fri, Jul 1, 2016 at 3:25 PM, Amit Kapila wrote: >> On Fri, Jul 1, 2016 at 8:48 AM, Thomas Munro >> wrote: >>> If serialized_snapshot->xcnt == 0, then

Re: [HACKERS] [sqlsmith] crashes in RestoreSnapshot on hot standby

2016-06-30 Thread Thomas Munro
On Fri, Jul 1, 2016 at 3:25 PM, Amit Kapila wrote: > On Fri, Jul 1, 2016 at 8:48 AM, Thomas Munro > wrote: >> If serialized_snapshot->xcnt == 0, then snapshot->xip never gets >> initialized to a non-NULL value. Then if

Re: [HACKERS] [sqlsmith] crashes in RestoreSnapshot on hot standby

2016-06-30 Thread Amit Kapila
On Fri, Jul 1, 2016 at 8:48 AM, Thomas Munro wrote: > > On Fri, Jul 1, 2016 at 2:17 PM, Michael Paquier > wrote: > > On Fri, Jul 1, 2016 at 6:26 AM, Andreas Seltenreich wrote: > >> #1 0x00822032 in

Re: [HACKERS] [sqlsmith] crashes in RestoreSnapshot on hot standby

2016-06-30 Thread Thomas Munro
On Fri, Jul 1, 2016 at 2:17 PM, Michael Paquier wrote: > On Fri, Jul 1, 2016 at 6:26 AM, Andreas Seltenreich > wrote: >> #1 0x00822032 in RestoreSnapshot >> (start_address=start_address@entry=0x7f2701d5a110 > memory at address

Re: [HACKERS] [sqlsmith] crashes in RestoreSnapshot on hot standby

2016-06-30 Thread Michael Paquier
On Fri, Jul 1, 2016 at 6:26 AM, Andreas Seltenreich wrote: > #1 0x00822032 in RestoreSnapshot > (start_address=start_address@entry=0x7f2701d5a110 memory at address 0x7f2701d5a110>) at snapmgr.c:2020 memcpy(snapshot->subxip, serialized_xids +