Re: [HACKERS] A bug in UCS_to_most.pl

[Kyotaro HORIGUCHI]

At Tue, 15 Nov 2016 09:44:54 -0500, Robert Haas  wrote 
in 
> On Tue, Nov 8, 2016 at 3:56 AM, Kyotaro HORIGUCHI
>  wrote:
> > I was surprised to find that
> > src/backend/utils/mb/Unicode/Makefile got changed (3a47c70) to
> > have download feature of character conversion authority files. It
> > seems fine according to the previous discussion as the commnet of
> > that is saying.
> >
> > So, I did 'make maintainer-clean; make' on it but got the
> > following error.
> >
> >> Hash %filename missing the % in argument 1 of keys() at UCS_to_most.pl 
> >> line 51.'/usr/bin/perl' UCS_to_most.pl
> >
> > What is more surprising to find that it is there since
> > 2006. Maybe Heikki unintentionally fixed that in the patch in the
> > thread, or older perls might not have complained about it (my
> > perl is 5.16).
> >
> > Anyway, the attached small patch fixes it.
> 
> It's quite amazing to me that that ever worked for anyone.  Committed.

Thanks.

As for myself, Probably I have never ran UCS_to_most.pl. Maybe no
one ran it since the patch.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A bug in UCS_to_most.pl

[Robert Haas]

On Tue, Nov 8, 2016 at 3:56 AM, Kyotaro HORIGUCHI
 wrote:
> I was surprised to find that
> src/backend/utils/mb/Unicode/Makefile got changed (3a47c70) to
> have download feature of character conversion authority files. It
> seems fine according to the previous discussion as the commnet of
> that is saying.
>
> So, I did 'make maintainer-clean; make' on it but got the
> following error.
>
>> Hash %filename missing the % in argument 1 of keys() at UCS_to_most.pl line 
>> 51.'/usr/bin/perl' UCS_to_most.pl
>
> What is more surprising to find that it is there since
> 2006. Maybe Heikki unintentionally fixed that in the patch in the
> thread, or older perls might not have complained about it (my
> perl is 5.16).
>
> Anyway, the attached small patch fixes it.

It's quite amazing to me that that ever worked for anyone.  Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers