Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-26 Thread Michael Paquier
Hi, Please find attached an updated patch (context diffs) improving the comments related to ALTER SYSTEM. This patch does nothing for the suffix tmp/temp used in a couple of places of the code, it only corrects some typos and makes the comments more consistent with current code. The

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-26 Thread Michael Paquier
On Mon, Jan 27, 2014 at 11:29 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi, Please find attached an updated patch (context diffs) improving the comments related to ALTER SYSTEM. This patch does nothing for the suffix tmp/temp used in a couple of places of the code, it only

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-26 Thread Fujii Masao
On Mon, Jan 27, 2014 at 11:53 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Jan 27, 2014 at 11:29 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi, Please find attached an updated patch (context diffs) improving the comments related to ALTER SYSTEM. This patch does

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-26 Thread Michael Paquier
On Mon, Jan 27, 2014 at 12:49 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Jan 27, 2014 at 11:53 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Jan 27, 2014 at 11:29 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi, Please find attached an updated patch (context

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-22 Thread Robert Haas
On Tue, Jan 21, 2014 at 7:02 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jan 22, 2014 at 5:29 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I agree with Michael that having pg_basebackup be aware of the .temp suffix is ugly; for instance if we were to fix it to .tmp in

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-21 Thread Michael Paquier
On Mon, Jan 20, 2014 at 2:12 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Sat, Jan 18, 2014 at 7:59 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I noticed a couple of typo mistakes as well as (I think) a

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-21 Thread Robert Haas
On Tue, Jan 21, 2014 at 7:47 AM, Michael Paquier michael.paqu...@gmail.com wrote: After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I noticed a couple of typo mistakes as well as (I think) a weird way of using the temporary auto-configuration name postgresql.auto.conf.temp in

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-21 Thread Alvaro Herrera
Robert Haas escribió: I don't think there's any real reason to defined PG_AUTOCONF_FILENAME_TEMP. pg_stat_statements just writes PGSS_DUMP_FILE .tmp and that hasn't been a problem that I know of. I do wonder why ALTER SYSTEM SET is spelling the suffix temp instead of tmp. I agree with

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-21 Thread Michael Paquier
On Wed, Jan 22, 2014 at 5:29 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I agree with Michael that having pg_basebackup be aware of the .temp suffix is ugly; for instance if we were to fix it to .tmp in ALTER SYSTEM but forgot to change pg_basebackup, the check would be immediately

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-21 Thread Amit Kapila
On Wed, Jan 22, 2014 at 1:15 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 21, 2014 at 7:47 AM, Michael Paquier michael.paqu...@gmail.com wrote: After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I noticed a couple of typo mistakes as well as (I think) a weird way of

Re: [HACKERS] ALTER SYSTEM SET typos and fix for temporary file name management

2014-01-19 Thread Amit Kapila
On Sat, Jan 18, 2014 at 7:59 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I noticed a couple of typo mistakes as well as (I think) a weird way of using the temporary auto-configuration name